Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybinds for powers, activating and deactivating #119

Open
leafreynolds opened this issue Nov 11, 2024 · 7 comments
Open

Keybinds for powers, activating and deactivating #119

leafreynolds opened this issue Nov 11, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@leafreynolds
Copy link
Owner

We should add a keybind for each power (no default set) so that people can tap it to activate, again to deactivate if active.

For allomancy, there should be two, one for flaring and one for normal burn.

Feruchemy undecided on default tap level. Could just go for max?

@leafreynolds leafreynolds added the enhancement New feature or request label Nov 11, 2024
@leafreynolds leafreynolds added this to the Cosmere milestone Nov 11, 2024
@SoaringEaqle
Copy link
Contributor

Just a few thoughts:
First, If you're also holding shift (for example) when you press an Allomancy activation keybind would set it to compound, holding alt (for example) would set it to flare, holding both while pressing the activate would flare-compound.
Second, you could reuse those key-binds for Feruchemy. You could have two tap/store levels configs (defaults of 4 and 15), then when you press the activate bind, it turns on the Feruchemic power to the first default, and if you press it while holding alt, it your power to tap at the second default or max (whichever is lower). In addition, if your hold shift, it will store at the respective levels.
Third, pressing the keybind while your power is already active (burning, flaring, compounding, tapping or storing), it should turn it off.

@SoaringEaqle
Copy link
Contributor

Actually, could I work on this?

@leafreynolds
Copy link
Owner Author

Actually, could I work on this?

Any time you see a task that isn’t actively being worked on, feel free to go ahead. Make a pull request too, linking to the ticket

@leafreynolds
Copy link
Owner Author

Actually, could I work on this?

Did you get a chance to work on this? :)

@SoaringEaqle
Copy link
Contributor

I started on it, so I believe all the constants and keybindings for Allomancy are in, I just needed to begin implementation. I got busy and kinda forgot, so thanks for reminding me I was doing this.

@SoaringEaqle
Copy link
Contributor

Just a few thoughts: First, If you're also holding shift (for example) when you press an Allomancy activation keybind would set it to compound, holding alt (for example) would set it to flare, holding both while pressing the activate would flare-compound. Second, you could reuse those key-binds for Feruchemy. You could have two tap/store levels configs (defaults of 4 and 15), then when you press the activate bind, it turns on the Feruchemic power to the first default, and if you press it while holding alt, it your power to tap at the second default or max (whichever is lower). In addition, if your hold shift, it will store at the respective levels. Third, pressing the keybind while your power is already active (burning, flaring, compounding, tapping or storing), it should turn it off.

Before I start, does this work for you? Any changes you would like made?

@leafreynolds
Copy link
Owner Author

Before I start, does this work for you? Any changes you would like made?

I wouldn't mind seeing it in game since it's hard to judge how it would feel. But what you've presented sounds good for trying.

You'll also need to be slightly careful of the keybind modifiers that are already in game, since we do already use buttons like shift and control to adjust how much of a change the mode increase/decrease is.

This is the section that deals with mode change keybinds, it happens in the cosmere library mod rather than any of the sub mods:

@leafreynolds leafreynolds moved this to 🏗 In progress in Cosmere Suite Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants