Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to 1.20.x #102

Open
9 of 10 tasks
leafreynolds opened this issue Mar 24, 2024 · 6 comments
Open
9 of 10 tasks

Port to 1.20.x #102

leafreynolds opened this issue Mar 24, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@leafreynolds
Copy link
Owner

leafreynolds commented Mar 24, 2024

Remaining work

  • Data generation code
  • Fix curio slots
  • metal vial custom recipe
  • tools itemgroup -> creative tabs
  • Feruchromium not increasing fortune
  • Cosmere copper ingots should be replaced with vanilla variant
  • Refactor all uses of SomeEnum.values() to one class, so as to not assign new memory when called. It should do it once on construction in a unified enumsutils class or something
  • initial settings for ore generation
  • fix vanilla night vision?
  • 1.20.+ sandmastery port QA pass #121
@leafreynolds leafreynolds added the enhancement New feature or request label Mar 24, 2024
@leafreynolds leafreynolds added this to the Cosmere milestone Mar 24, 2024
@leafreynolds leafreynolds self-assigned this Mar 24, 2024
@DiceOf20
Copy link
Contributor

DiceOf20 commented May 1, 2024

Best of luck Leaf!!

@R0b0r0b
Copy link

R0b0r0b commented May 1, 2024

Good luck Leaf, you can do it!!
Strength before Weakness!

@leafreynolds leafreynolds moved this to 🏗 In progress in Cosmere Suite Oct 3, 2024
@DiceOf20 DiceOf20 linked a pull request Oct 11, 2024 that will close this issue
@Gerbagel
Copy link
Collaborator

Gerbagel commented Nov 3, 2024

Fixed f-chromium in 9480f55

@R0b0r0b
Copy link

R0b0r0b commented Nov 3, 2024

Nice one, Gerbagel!
Though Leaf, I'm not sure that you should replace Cosmere copper ingots with vanilla ones - I've found that vanilla copper, once it's become exposed or weathered, no longer qualifies as Pushable/Pullable.
(Or just make the weathered/exposed variants also Pushable/Pullable, now I think about it!)

@Gerbagel
Copy link
Collaborator

Gerbagel commented Nov 3, 2024

Nice one, Gerbagel!
Though Leaf, I'm not sure that you should replace Cosmere copper ingots with vanilla ones - I've found that vanilla copper, once it's become exposed or weathered, no longer qualifies as Pushable/Pullable.
(Or just make the weathered/exposed variants also Pushable/Pullable, now I think about it!)

This we fix :)
Should just be a datapack change to add those specifically as pushable

@leafreynolds
Copy link
Owner Author

@MoonlitJolteon Let me know when you get a chance to check Sandmastery :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

4 participants