Merge pull request #1093 from Thirumalai-Shaktivel/out_of_range

Author: Thirumalai-Shaktivel

src/bin/lpython.cpp

@@ -927,8 +927,8 @@ int link_executable(const std::vector<std::string> &infiles,
                 std::cout << "The command '" + cmd + "' failed." << std::endl;
                 return 10;
             }
-            if (outfile == "a.out" && compiler_options.arg_o == "") {
-                err = system("a.out");
+            if (compiler_options.arg_o == "") {
+                err = system(outfile.c_str());
                 if (err != 0) {
                     if (0 < err && err < 256) {
                         return err;
@@ -962,8 +962,8 @@ int link_executable(const std::vector<std::string> &infiles,
                 std::cout << "The command '" + cmd + "' failed." << std::endl;
                 return 10;
             }
-            if (outfile == "a.out" && compiler_options.arg_o == "") {
-                err = system("./a.out");
+            if (compiler_options.arg_o == "") {
+                err = system(("./" + outfile).c_str());
                 if (err != 0) {
                     if (0 < err && err < 256) {
                         return err;
@@ -1282,6 +1282,7 @@ int main(int argc, char *argv[])
         app.add_flag("--no-warnings", compiler_options.no_warnings, "Turn off all warnings");
         app.add_flag("--no-error-banner", compiler_options.no_error_banner, "Turn off error banner");
         app.add_option("--backend", arg_backend, "Select a backend (llvm, cpp, x86, wasm, wasm_x86)")->capture_default_str();
+        app.add_flag("--enable-bounds-checking", compiler_options.enable_bounds_checking, "Turn on index bounds checking");
         app.add_flag("--openmp", compiler_options.openmp, "Enable openmp");
         app.add_flag("--fast", compiler_options.fast, "Best performance (disable strict standard compliance)");
         app.add_option("--target", compiler_options.target, "Generate code for the given target")->capture_default_str();
@@ -1292,10 +1293,6 @@ int main(int argc, char *argv[])
         app.add_flag("--show-errors", show_errors, "Show errors when LSP is running in the background");
         app.add_flag("--show-document-symbols", show_document_symbols, "Show symbols in lpython file");
 
-        if( compiler_options.fast ) {
-            lpython_pass_manager.use_optimization_passes();
-        }
-
         /*
         * Subcommands:
         */
@@ -1328,6 +1325,16 @@ int main(int argc, char *argv[])
         app.require_subcommand(0, 1);
         CLI11_PARSE(app, argc, argv);
 
+        if( compiler_options.fast && compiler_options.enable_bounds_checking ) {
+        // ReleaseSafe Mode
+        } else if ( compiler_options.fast ) {
+        // Release Mode
+            lpython_pass_manager.use_optimization_passes();
+        } else {
+        // Debug Mode
+            compiler_options.enable_bounds_checking = true;
+        }
+
         if (arg_version) {
             std::string version = LFORTRAN_VERSION;
             std::cout << "LPython version: " << version << std::endl;
@@ -1434,7 +1441,7 @@ int main(int argc, char *argv[])
         } else if (show_wat) {
             outfile = basename + ".wat";
         } else {
-            outfile = "a.out";
+            outfile = basename + ".out";
         }
 
         // if (arg_E) {

src/libasr/codegen/asr_to_llvm.cpp

@@ -164,6 +164,7 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor<ASRToLLVMVisitor>
     bool emit_debug_info;
     std::string infile;
     bool emit_debug_line_column;
+    bool enable_bounds_checking;
     Allocator &al;
 
     llvm::Value *tmp;
@@ -242,14 +243,15 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor<ASRToLLVMVisitor>
 
     ASRToLLVMVisitor(Allocator &al, llvm::LLVMContext &context, Platform platform,
         bool emit_debug_info, std::string infile, bool emit_debug_line_column,
-        diag::Diagnostics &diagnostics) :
+        bool enable_bounds_checking, diag::Diagnostics &diagnostics) :
     diag{diagnostics},
     context(context),
     builder(std::make_unique<llvm::IRBuilder<>>(context)),
     platform{platform},
     emit_debug_info{emit_debug_info},
     infile{infile},
     emit_debug_line_column{emit_debug_line_column},
+    enable_bounds_checking{enable_bounds_checking},
     al{al},
     prototype_only(false),
     llvm_utils(std::make_unique<LLVMUtils>(context, builder.get())),
@@ -1381,7 +1383,7 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor<ASRToLLVMVisitor>
             this->visit_expr(*x.m_args[i]);
             llvm::Value* item = tmp;
             llvm::Value* pos = llvm::ConstantInt::get(context, llvm::APInt(32, i));
-            list_api->write_item(const_list, pos, item, list_type->m_type, *module);
+            list_api->write_item(const_list, pos, item, list_type->m_type, false, *module);
         }
         ptr_loads = ptr_loads_copy;
         tmp = const_list;
@@ -1521,9 +1523,8 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor<ASRToLLVMVisitor>
         ptr_loads = ptr_loads_copy;
         llvm::Value *pos = tmp;
 
-        tmp = list_api->read_item(plist, pos,
-                (LLVM::is_llvm_struct(el_type) ||
-                ptr_loads == 0));
+        tmp = list_api->read_item(plist, pos, enable_bounds_checking, *module,
+                (LLVM::is_llvm_struct(el_type) || ptr_loads == 0));
     }
 
     void visit_DictItem(const ASR::DictItem_t& x) {
@@ -3916,7 +3917,9 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor<ASRToLLVMVisitor>
                 llvm::Value* list = tmp;
                 this->visit_expr_wrapper(asr_target0->m_pos, true);
                 llvm::Value* pos = tmp;
-                target = list_api->read_item(list, pos, true);
+
+                target = list_api->read_item(list, pos, enable_bounds_checking,
+                                             *module, true);
             }
         } else {
             ASR::Variable_t *asr_target = EXPR2VAR(x.m_target);
@@ -6399,7 +6402,7 @@ Result<std::unique_ptr<LLVMModule>> asr_to_llvm(ASR::TranslationUnit_t &asr,
     context.setOpaquePointers(false);
 #endif
     ASRToLLVMVisitor v(al, context, co.platform, co.emit_debug_info, infile,
-        co.emit_debug_line_column, diagnostics);
+        co.emit_debug_line_column, co.enable_bounds_checking, diagnostics);
     LCompilers::PassOptions pass_options;
     pass_options.run_fun = run_fn;
     pass_options.always_run = false;