Skip to content

Commit 3dd0925

Browse files
authored
Honor default enabled for instrumentation modules (open-telemetry#10211)
1 parent 6ce3bd8 commit 3dd0925

File tree

6 files changed

+7
-6
lines changed

6 files changed

+7
-6
lines changed

instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/logging/ApplicationLoggingInstrumentationModule.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ public ApplicationLoggingInstrumentationModule() {
2323
@Override
2424
public boolean defaultEnabled(ConfigProperties config) {
2525
// only enable this instrumentation if the application logger is enabled
26-
return "application".equals(config.getString("otel.javaagent.logging"));
26+
return super.defaultEnabled(config)
27+
&& "application".equals(config.getString("otel.javaagent.logging"));
2728
}
2829

2930
@Override

instrumentation/jaxrs/jaxrs-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v1_0/JaxrsInstrumentationModule.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,6 @@ public boolean defaultEnabled(ConfigProperties config) {
3939
// This instrumentation produces controller telemetry and sets http route. Http route is set by
4040
// this instrumentation only when it was not already set by a jax-rs framework instrumentation.
4141
// This instrumentation uses complex type matcher, disabling it can improve startup performance.
42-
return ExperimentalConfig.get().controllerTelemetryEnabled();
42+
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
4343
}
4444
}

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/JaxrsAnnotationsInstrumentationModule.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,6 @@ public boolean defaultEnabled(ConfigProperties config) {
4242
// This instrumentation produces controller telemetry and sets http route. Http route is set by
4343
// this instrumentation only when it was not already set by a jax-rs framework instrumentation.
4444
// This instrumentation uses complex type matcher, disabling it can improve startup performance.
45-
return ExperimentalConfig.get().controllerTelemetryEnabled();
45+
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
4646
}
4747
}

instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v3_0/JaxrsAnnotationsInstrumentationModule.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,6 @@ public boolean defaultEnabled(ConfigProperties config) {
4242
// This instrumentation produces controller telemetry and sets http route. Http route is set by
4343
// this instrumentation only when it was not already set by a jax-rs framework instrumentation.
4444
// This instrumentation uses complex type matcher, disabling it can improve startup performance.
45-
return ExperimentalConfig.get().controllerTelemetryEnabled();
45+
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
4646
}
4747
}

instrumentation/jaxws/jaxws-jws-api-1.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxws/jws/v1_1/JwsInstrumentationModule.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@ public List<TypeInstrumentation> typeInstrumentations() {
2828
@Override
2929
public boolean defaultEnabled(ConfigProperties config) {
3030
// this instrumentation only produces controller telemetry
31-
return ExperimentalConfig.get().controllerTelemetryEnabled();
31+
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
3232
}
3333
}

instrumentation/spring/spring-ws-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/ws/v2_0/SpringWsInstrumentationModule.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ public List<TypeInstrumentation> typeInstrumentations() {
2727
@Override
2828
public boolean defaultEnabled(ConfigProperties config) {
2929
// this instrumentation only produces controller telemetry
30-
return ExperimentalConfig.get().controllerTelemetryEnabled();
30+
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
3131
}
3232
}

0 commit comments

Comments
 (0)