Skip to content

Commit a495562

Browse files
authored
chore: Add missing make target; update poetry instructions (#338)
1 parent a8eeb1e commit a495562

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
- uses: ./.github/actions/build-docs
4848

4949
- name: Run tests
50-
run: make test
50+
run: make test-all
5151

5252
- name: Verify typehints
5353
run: make lint
@@ -124,4 +124,4 @@ jobs:
124124
run: poetry install --all-extras
125125

126126
- name: Run tests
127-
run: make test
127+
run: make test-all

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ We encourage pull requests and other contributions from the community. Before su
1616

1717
This project is built using [poetry](https://python-poetry.org/). To learn more about the basics of working with this tool, read [Poetry's basic usage guide](https://python-poetry.org/docs/basic-usage/).
1818

19-
To begin development, active the poetry shell and ensure your dependencies are installed.
19+
To begin development, ensure your dependencies are installed and (optionally) activate the virtualenv.
2020

2121
```
22-
poetry shell
2322
poetry install
23+
eval $(poetry env activate)
2424
```
2525

2626
This library defines several extra dependencies to optionally enhance the SDK's capabilities. Use the following commands to install one or more of the available extras.

Makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ install:
2828
.PHONY: test
2929
test: #! Run unit tests
3030
test: install
31+
@LD_SKIP_DATABASE_TESTS=1 poetry run pytest $(PYTEST_FLAGS)
32+
33+
.PHONY: test-all
34+
test-all: #! Run unit tests (including database integrations)
35+
test-all: install
3136
@poetry run pytest $(PYTEST_FLAGS)
3237

3338
.PHONY: lint

0 commit comments

Comments
 (0)