Skip to content

Commit 965527d

Browse files
authored
chore: Drop python 3.8 test support (#334)
Python 3.8 has been EOL since October of 2024. As a result, builds are starting to fail because tooling support is moving on. To combat this, we are bumping our testing to only include 3.9 or higher.
1 parent dd2f562 commit 965527d

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ name: Quality control checks
22

33
on:
44
push:
5-
branches: [ main, 'feat/**' ]
5+
branches: [main, "feat/**"]
66
paths-ignore:
7-
- '**.md' # Do not need to run CI for markdown changes.
7+
- "**.md" # Do not need to run CI for markdown changes.
88
pull_request:
9-
branches: [ main, 'feat/**' ]
9+
branches: [main, "feat/**"]
1010
paths-ignore:
11-
- '**.md'
11+
- "**.md"
1212

1313
jobs:
1414
linux:
@@ -17,7 +17,7 @@ jobs:
1717
strategy:
1818
fail-fast: false
1919
matrix:
20-
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
20+
python-version: ["3.9", "3.10", "3.11", "3.12"]
2121

2222
services:
2323
redis:
@@ -77,7 +77,7 @@ jobs:
7777
strategy:
7878
fail-fast: false
7979
matrix:
80-
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
80+
python-version: ["3.9", "3.10", "3.11", "3.12"]
8181

8282
steps:
8383
- uses: actions/checkout@v4

.github/workflows/manual-publish.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ on:
33
workflow_dispatch:
44
inputs:
55
dry_run:
6-
description: 'Is this a dry run? If so no package will be published.'
6+
description: "Is this a dry run? If so no package will be published."
77
type: boolean
88
required: true
99

@@ -21,16 +21,16 @@ jobs:
2121

2222
- uses: actions/setup-python@v5
2323
with:
24-
python-version: 3.8
24+
python-version: 3.9
2525

2626
- name: Install poetry
2727
uses: abatilo/actions-poetry@7b6d33e44b4f08d7021a1dee3c044e9c253d6439
2828

2929
- uses: launchdarkly/gh-actions/actions/[email protected]
30-
name: 'Get PyPI token'
30+
name: "Get PyPI token"
3131
with:
3232
aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
33-
ssm_parameter_pairs: '/production/common/releasing/pypi/token = PYPI_AUTH_TOKEN'
33+
ssm_parameter_pairs: "/production/common/releasing/pypi/token = PYPI_AUTH_TOKEN"
3434

3535
- uses: ./.github/actions/build
3636
id: build
@@ -42,7 +42,7 @@ jobs:
4242
password: ${{env.PYPI_AUTH_TOKEN}}
4343

4444
release-provenance:
45-
needs: [ 'build-publish' ]
45+
needs: ["build-publish"]
4646
permissions:
4747
actions: read
4848
id-token: write

.github/workflows/release-please.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Run Release Please
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [main]
66

77
jobs:
88
release-package:
@@ -27,18 +27,18 @@ jobs:
2727
- uses: actions/setup-python@v5
2828
if: ${{ steps.release.outputs.releases_created == 'true' }}
2929
with:
30-
python-version: 3.8
30+
python-version: 3.9
3131

3232
- name: Install poetry
3333
if: ${{ steps.release.outputs.releases_created == 'true' }}
3434
uses: abatilo/actions-poetry@7b6d33e44b4f08d7021a1dee3c044e9c253d6439
3535

3636
- uses: launchdarkly/gh-actions/actions/[email protected]
3737
if: ${{ steps.release.outputs.releases_created == 'true' }}
38-
name: 'Get PyPI token'
38+
name: "Get PyPI token"
3939
with:
4040
aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
41-
ssm_parameter_pairs: '/production/common/releasing/pypi/token = PYPI_AUTH_TOKEN'
41+
ssm_parameter_pairs: "/production/common/releasing/pypi/token = PYPI_AUTH_TOKEN"
4242

4343
- uses: ./.github/actions/build
4444
id: build
@@ -54,7 +54,7 @@ jobs:
5454
password: ${{env.PYPI_AUTH_TOKEN}}
5555

5656
release-provenance:
57-
needs: [ 'release-package' ]
57+
needs: ["release-package"]
5858
if: ${{ needs.release-package.outputs.release-created == 'true' }}
5959
permissions:
6060
actions: read

0 commit comments

Comments
 (0)