clarify log message

Author: eli-darkly

src/main/java/com/launchdarkly/client/DefaultEventProcessor.java

@@ -390,7 +390,10 @@ private void handleResponse(Response response) {
       }
       if (!isHttpErrorRecoverable(response.code())) {
         disabled.set(true);
-        logger.error(httpErrorMessage(response.code(), "posting events"));
+        logger.error(httpErrorMessage(response.code(), "posting events", "some events were dropped"));
+        // It's "some events were dropped" because we're not going to retry *this* request any more times -
+        // we only get to this point if we have used up our retry attempts. So the last batch of events was
+        // lost, even though we will still try to post *other* events in the future.
       }
     }
   }

src/main/java/com/launchdarkly/client/PollingProcessor.java

@@ -64,7 +64,7 @@ public void run() {
             initFuture.set(null);
           }
         } catch (HttpErrorException e) {
-          logger.error(httpErrorMessage(e.getStatus(), "polling request"));
+          logger.error(httpErrorMessage(e.getStatus(), "polling request", "will retry"));
           if (!isHttpErrorRecoverable(e.getStatus())) {
             scheduler.shutdown();
             initFuture.set(null); // if client is initializing, make it stop waiting; has no effect if already inited

src/main/java/com/launchdarkly/client/StreamProcessor.java

@@ -69,7 +69,7 @@ public Future<Void> start() {
       public Action onConnectionError(Throwable t) {
         if (t instanceof UnsuccessfulResponseException) {
           int status = ((UnsuccessfulResponseException)t).getCode();
-          logger.error(httpErrorMessage(status, "streaming connection"));
+          logger.error(httpErrorMessage(status, "streaming connection", "will retry"));
           if (!isHttpErrorRecoverable(status)) {
             initFuture.set(null); // if client is initializing, make it stop waiting; has no effect if already inited
             return Action.SHUTDOWN;

src/main/java/com/launchdarkly/client/Util.java

@@ -35,7 +35,7 @@ static Request.Builder getRequestBuilder(String sdkKey) {
 
   /**
    * Tests whether an HTTP error status represents a condition that might resolve on its own if we retry.
-   * @param statusCode
+   * @param statusCode the HTTP status
    * @return true if retrying makes sense; false if it should be considered a permanent failure
    */
   static boolean isHttpErrorRecoverable(int statusCode) {
@@ -51,16 +51,23 @@ static boolean isHttpErrorRecoverable(int statusCode) {
     return true;
   }
 
-  static String httpErrorMessage(int statusCode, String context) {
+  /**
+   * Builds an appropriate log message for an HTTP error status.
+   * @param statusCode the HTTP status
+   * @param context description of what we were trying to do
+   * @param recoverableMessage description of our behavior if the error is recoverable; typically "will retry"
+   * @return a message string
+   */
+  static String httpErrorMessage(int statusCode, String context, String recoverableMessage) {
     StringBuilder sb = new StringBuilder();
     sb.append("Received HTTP error ").append(statusCode);
     switch (statusCode) {
     case 401:
     case 403:
       sb.append(" (invalid SDK key)");
     }
-    sb.append(" for ").append(context);
-    sb.append(isHttpErrorRecoverable(statusCode) ? " - will retry " : " - will not retry");
+    sb.append(" for ").append(context).append(" - ");
+    sb.append(isHttpErrorRecoverable(statusCode) ? recoverableMessage : "giving up permanently");
     return sb.toString();
   }
 }