prepare 4.11.1 release (#185)

Author: LaunchDarklyCI

CHANGELOG.md

@@ -6,9 +6,6 @@ All notable changes to the LaunchDarkly Java SDK will be documented in this file
 ### Added:
 - When an `EvaluationReason` indicates that flag evaluation failed due to an unexpected exception (`getKind()` is `ERROR`, and `EvaluationReason.Error.getErrorKind()` is `EXCEPTION`), you can now examine the underlying exception via `EvaluationReason.Error.getException()`. ([#180](https://github.com/launchdarkly/java-server-sdk/issues/180))
 
-### Fixed:
-- The SDK now specifies a uniquely identifiable request header when sending events to LaunchDarkly to ensure that events are only processed once, even if the SDK sends them two times due to a failed initial attempt.
-
 ## [4.10.1] - 2020-01-06
 ### Fixed:
 - The `pom.xml` dependencies were incorrectly specifying `runtime` scope rather than `compile`, causing problems for applications that did not have their own dependencies on Gson and SLF4J. ([#151](https://github.com/launchdarkly/java-client/issues/151))

src/main/java/com/launchdarkly/client/EvaluationReason.java

@@ -1,5 +1,14 @@
 package com.launchdarkly.client;
 
+import com.google.gson.Gson;
+import com.google.gson.TypeAdapter;
+import com.google.gson.TypeAdapterFactory;
+import com.google.gson.annotations.JsonAdapter;
+import com.google.gson.reflect.TypeToken;
+import com.google.gson.stream.JsonReader;
+import com.google.gson.stream.JsonWriter;
+
+import java.io.IOException;
 import java.util.Objects;
 
 import static com.google.common.base.Preconditions.checkNotNull;
@@ -317,7 +326,10 @@ private Fallthrough()
    */
   public static class Error extends EvaluationReason {
     private final ErrorKind errorKind;
-    private final Exception exception;
+    private transient final Exception exception;
+    // The exception field is transient because we don't want it to be included in the JSON representation that
+    // is used in analytics events; the LD event service wouldn't know what to do with it (and it would include
+    // a potentially large amount of stacktrace data).
 
     private Error(ErrorKind errorKind, Exception exception) {
       super(Kind.ERROR);

src/main/java/com/launchdarkly/client/FeatureStoreCacheConfig.java

@@ -161,6 +161,9 @@ public StaleValuesPolicy getStaleValuesPolicy() {
    * Specifies the cache TTL. Items will be evicted or refreshed (depending on {@link #staleValuesPolicy(StaleValuesPolicy)})
    * after this amount of time from the time when they were originally cached. If the time is less
    * than or equal to zero, caching is disabled.
+   * after this amount of time from the time when they were originally cached.
+   * <p>
+   * If the value is zero, caching is disabled.
    * 
    * @param cacheTime the cache TTL in whatever units you wish
    * @param timeUnit the time unit

src/main/java/com/launchdarkly/client/OperandType.java

@@ -27,6 +27,9 @@ public Object getValueAsType(LDValue value) {
     case date:
       return Util.jsonPrimitiveToDateTime(value);
     case semVer:
+      if (!value.isString()) {
+        return null;
+      }
       try {
         return SemanticVersion.parse(value.stringValue(), true);
       } catch (SemanticVersion.InvalidVersionException e) {

src/test/java/com/launchdarkly/client/EvaluationReasonTest.java

@@ -54,10 +54,20 @@ public void testPrerequisiteFailedSerialization() {
 
   @Test
   public void testErrorSerialization() {
-    EvaluationReason reason = EvaluationReason.error(EvaluationReason.ErrorKind.EXCEPTION);
+    EvaluationReason reason = EvaluationReason.error(EvaluationReason.ErrorKind.FLAG_NOT_FOUND);
+    String json = "{\"kind\":\"ERROR\",\"errorKind\":\"FLAG_NOT_FOUND\"}";
+    assertJsonEqual(json, gson.toJson(reason));
+    assertEquals("ERROR(FLAG_NOT_FOUND)", reason.toString());
+  }
+
+  @Test
+  public void testErrorSerializationWithException() {
+    // We do *not* want the JSON representation to include the exception, because that is used in events, and
+    // the LD event service won't know what to do with that field (which will also contain a big stacktrace).
+    EvaluationReason reason = EvaluationReason.exception(new Exception("something happened"));
     String json = "{\"kind\":\"ERROR\",\"errorKind\":\"EXCEPTION\"}";
     assertJsonEqual(json, gson.toJson(reason));
-    assertEquals("ERROR(EXCEPTION)", reason.toString());
+    assertEquals("ERROR(EXCEPTION,java.lang.Exception: something happened)", reason.toString());
   }
 
   @Test

src/test/java/com/launchdarkly/client/OperatorParameterizedTest.java

@@ -115,7 +115,13 @@ public static Iterable<Object[]> data() {
       { Operator.semVerGreaterThan, LDValue.of("2.0"), LDValue.of("2.0.1"), false },
       { Operator.semVerGreaterThan, LDValue.of("2.0.0-rc.1"), LDValue.of("2.0.0-rc.0"), true },
       { Operator.semVerLessThan, LDValue.of("2.0.1"), invalidVer, false },
-      { Operator.semVerGreaterThan, LDValue.of("2.0.1"), invalidVer, false }
+      { Operator.semVerGreaterThan, LDValue.of("2.0.1"), invalidVer, false },
+      { Operator.semVerEqual, LDValue.ofNull(), LDValue.of("2.0.0"), false },
+      { Operator.semVerEqual, LDValue.of(1), LDValue.of("2.0.0"), false },
+      { Operator.semVerEqual, LDValue.of(true), LDValue.of("2.0.0"), false },
+      { Operator.semVerEqual, LDValue.of("2.0.0"), LDValue.ofNull(), false },
+      { Operator.semVerEqual, LDValue.of("2.0.0"), LDValue.of(1), false },
+      { Operator.semVerEqual, LDValue.of("2.0.0"), LDValue.of(true), false }
     });
   }