Merge pull request #74 from launchdarkly/eb/ch18860/fail-fast-in-init

fail fast in initialization if there's a 401

Author: eli-darkly

src/main/java/com/launchdarkly/client/LDClient.java

@@ -97,6 +97,9 @@ public LDClient(String sdkKey, LDConfig config) {
       } catch (Exception e) {
         logger.error("Exception encountered waiting for LaunchDarkly client initialization", e);
       }
+      if (!updateProcessor.initialized()) {
+        logger.warn("LaunchDarkly client was not successfully initialized");
+      }
     }
   }
 

src/main/java/com/launchdarkly/client/PollingProcessor.java

@@ -58,6 +58,7 @@ public void run() {
         } catch (FeatureRequestor.InvalidSDKKeyException e) {
           logger.error("Received 401 error, no further polling requests will be made since SDK key is invalid");
           scheduler.shutdown();
+          initFuture.set(null); // if client is initializing, make it stop waiting; has no effect if already inited
         } catch (IOException e) {
           logger.error("Encountered exception in LaunchDarkly client when retrieving update", e);
         }

src/main/java/com/launchdarkly/client/StreamProcessor.java

@@ -68,6 +68,7 @@ public Action onConnectionError(Throwable t) {
         if ((t instanceof UnsuccessfulResponseException) &&
             ((UnsuccessfulResponseException) t).getCode() == 401) {
           logger.error("Received 401 error, no further streaming connection will be made since SDK key is invalid");
+          initFuture.set(null); // if client is initializing, make it stop waiting; has no effect if already inited
           return Action.SHUTDOWN;
         }
         return Action.PROCEED;

src/test/java/com/launchdarkly/client/LDClientTest.java

@@ -109,7 +109,7 @@ public void willWaitForUpdateProcessorIfWaitMillisIsNonZero() throws Exception {
 
     expect(updateProcessor.start()).andReturn(initFuture);
     expect(initFuture.get(10L, TimeUnit.MILLISECONDS)).andReturn(null);
-    expect(updateProcessor.initialized()).andReturn(false);
+    expect(updateProcessor.initialized()).andReturn(false).anyTimes();
     replayAll();
 
     client = createMockClient(config);
@@ -125,7 +125,7 @@ public void updateProcessorCanTimeOut() throws Exception {
 
     expect(updateProcessor.start()).andReturn(initFuture);
     expect(initFuture.get(10L, TimeUnit.MILLISECONDS)).andThrow(new TimeoutException());
-    expect(updateProcessor.initialized()).andReturn(false);
+    expect(updateProcessor.initialized()).andReturn(false).anyTimes();
     replayAll();
 
     client = createMockClient(config);
@@ -141,7 +141,7 @@ public void clientCatchesRuntimeExceptionFromUpdateProcessor() throws Exception
 
     expect(updateProcessor.start()).andReturn(initFuture);
     expect(initFuture.get(10L, TimeUnit.MILLISECONDS)).andThrow(new RuntimeException());
-    expect(updateProcessor.initialized()).andReturn(false);
+    expect(updateProcessor.initialized()).andReturn(false).anyTimes();
     replayAll();
 
     client = createMockClient(config);

src/test/java/com/launchdarkly/client/PollingProcessorTest.java

@@ -53,4 +53,28 @@ public void testConnectionProblem() throws Exception {
     pollingProcessor.close();
     verifyAll();
   }
+  
+  @Test
+  public void signalsImmediateFailureOn401Error() throws Exception {
+    FeatureRequestor requestor = createStrictMock(FeatureRequestor.class);
+    PollingProcessor pollingProcessor = new PollingProcessor(LDConfig.DEFAULT, requestor, new InMemoryFeatureStore());
+
+    expect(requestor.getAllData())
+        .andThrow(new FeatureRequestor.InvalidSDKKeyException())
+        .once();
+    replayAll();
+
+    long startTime = System.currentTimeMillis();
+    Future<Void> initFuture = pollingProcessor.start();
+    try {
+      initFuture.get(10, TimeUnit.SECONDS);
+    } catch (TimeoutException ignored) {
+      fail("Should not have timed out");
+    }
+    assertTrue((System.currentTimeMillis() - startTime) < 9000);
+    assertTrue(initFuture.isDone());
+    assertFalse(pollingProcessor.initialized());
+    pollingProcessor.close();
+    verifyAll();
+  }
 }

src/test/java/com/launchdarkly/client/StreamProcessorTest.java

@@ -14,6 +14,8 @@
 import java.net.URI;
 import java.util.Collections;
 import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
 
 import static com.launchdarkly.client.TestUtil.specificFeatureStore;
 import static com.launchdarkly.client.VersionedDataKind.FEATURES;
@@ -23,6 +25,7 @@
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 import okhttp3.Headers;
 
@@ -296,6 +299,24 @@ public void streamWillCloseAfterHttp401Error() throws Exception {
     assertEquals(ConnectionErrorHandler.Action.SHUTDOWN, action);
   }
 
+  @Test
+  public void processorSignalsImmediateFailureAfter401Error() throws Exception {
+    UnsuccessfulResponseException e = new UnsuccessfulResponseException(401);
+    long startTime = System.currentTimeMillis();
+    StreamProcessor sp = createStreamProcessor(SDK_KEY, configBuilder.build());
+    Future<Void> initFuture = sp.start();
+    
+    errorHandler.onConnectionError(e);
+    try {
+      initFuture.get(10, TimeUnit.SECONDS);
+    } catch (TimeoutException ignored) {
+      fail("Should not have timed out");
+    }
+    assertTrue((System.currentTimeMillis() - startTime) < 9000);
+    assertTrue(initFuture.isDone());
+    assertFalse(sp.initialized());
+  }
+  
   private StreamProcessor createStreamProcessor(String sdkKey, LDConfig config) {
     return new StreamProcessor(sdkKey, config, mockRequestor, featureStore, new StubEventSourceCreator());
   }