`sqlx-cli@0.8.4` broke `.env` default resolution mechanism

[vegardgs-ksat]

I have found these related issues/pull requests

No related issues.

Description

Running sqlx-cli with version 0.8.4 version doesn't respect .env files (for DATABASE_URL) as expected.

In the changelog for 0.8.4, this PR adds a --no-dotenv flag, but that does indeed seem to set the default value to false, e.g., resolve .env files.

Reproduction steps

mkdir scratch && cd scratch
cargo install sqlx-cli --version 0.8.3 --root 0.8.3
cargo install sqlx-cli --version 0.8.4 --root 0.8.4
echo "DATABASE_URL=sqlite:tmp.db" >> .env
./0.8.3/bin/sqlx database create
./0.8.4/bin/sqlx database create

Observe that the 0.8.3 command succeeds, whilst the 0.8.4 command complains about no DATABASE_URL.

SQLx version

0.8.4

Enabled SQLx features

default

Database server and version

any

Operating system

macOS

Rust version

1.86

[krishnaTORQUE]

Indeed. I can confirm, I am having the same issue.

Even passing the url in cli does not work.

cargo sqlx prepare --database-url postgres://dev:dev@localhost/dev

[abonander]

It's because #3724 changed the behavior to call Cli::parse() before dotenvy::dotenvy(), but it uses Clap to read the database URL from the environment. Chicken-and-egg problem.

I'm working on a hotfix.

[c0nscience]

I must have run into this problem. I am not sure, because I did not get any error messages hinting towards a missing environment variable or anything. But pinning the version back to 0.8.3 solved the issue for now and I am able to generate offline data for the queries.

[krishnaTORQUE]

Should be re-open.

Having the same issue even after v0.8.5, still unable to execute "cargo sql prepare".

Not taking from .env file, not from --database-url

[abonander]

@krishnaTORQUE I cannot reproduce the issue with 0.8.5. Also, --database-url was not affected to begin with.

What is the actual error you are getting?

[krishnaTORQUE]

@abonander

I am getting the error below

error: SQLX_OFFLINE=true but there is no cached data for this query, run cargo sqlx prepare to update the query cache or unset SQLX_OFFLINE

But SQLX_OFFLINE=true & DATABASE_URL=postgres://dev:dev@localhost/dev is set & still unable to run cargo sqlx prepare

[abonander]

That's a new issue, actually.