docs: type ascription deprecation

Author: saiintbrisson

sqlx-macros-core/src/query/args.rs

@@ -32,8 +32,6 @@ pub fn quote_args<DB: DatabaseExt>(
         #(let #arg_name = &(#arg_expr);)*
     };
 
-    let mut args_warnings: Vec<TokenStream> = vec![];
-
     let args_check = match info.parameters() {
         None | Some(Either::Right(_)) => {
             // all we can do is check arity which we did
@@ -52,14 +50,11 @@ pub fn quote_args<DB: DatabaseExt>(
                 .enumerate()
                 .map(|(i, (param_ty, (name, expr)))| -> crate::Result<_> {
                     let param_ty = match get_type_override(expr) {
-                        // cast or type ascription will fail to compile if the type does not match
+                        // cast will fail to compile if the type does not match
                         // and we strip casts to wildcard
                         Some((_, false)) => return Ok(quote!()),
-                        Some((ty, true)) => {
-                            let warning = create_warning(name.clone(), ty.clone(), expr.clone());
-                            args_warnings.push(warning);
-                            return Ok(quote!())
-                        },
+                        // type ascription is deprecated
+                        Some((ty, true)) => return Ok(create_warning(name.clone(), &ty, &expr)),
                         None => {
                             DB::param_type_for_id(&param_ty)
                                 .ok_or_else(|| {
@@ -108,8 +103,6 @@ pub fn quote_args<DB: DatabaseExt>(
     let args_count = input.arg_exprs.len();
 
     Ok(quote! {
-        #(#args_warnings)*
-
         #arg_bindings
 
         #args_check
@@ -123,12 +116,12 @@ pub fn quote_args<DB: DatabaseExt>(
     })
 }
 
-fn create_warning(name: Ident, ty: Type, expr: Expr) -> TokenStream {
-    let span = expr.span();
-    let stripped = strip_wildcard(expr).to_token_stream();
-    let current = quote!(#stripped: #ty).to_string();
+fn create_warning(name: Ident, ty: &Type, expr: &Expr) -> TokenStream {
+    let current = expr.to_token_stream().to_string();
+    let Expr::Type(ExprType { expr: stripped, .. }) = expr else {
+        return quote!();
+    };
     let fix = quote!(#stripped as #ty).to_string();
-
     let message = format!(
         "
 \t\tType ascription pattern is deprecated, prefer casting
@@ -140,12 +133,15 @@ fn create_warning(name: Ident, ty: Type, expr: Expr) -> TokenStream {
 \t\tSee <https://github.com/rust-lang/rfcs/pull/3307> for more information
 "
     );
-    let name = Ident::new(&format!("warning_{name}"), span);
-    quote_spanned!(span =>
-        #[deprecated(note = #message)]
-        #[allow(non_upper_case_globals)]
-        const #name: () = ();
-        let _ = #name;
+    let name = Ident::new(&format!("warning_{name}"), expr.span());
+    quote_spanned!(expr.span() =>
+        // this shouldn't actually run
+        if false {
+            #[deprecated(note = #message)]
+            #[allow(non_upper_case_globals)]
+            const #name: () = ();
+            let _ = #name;
+        }
     )
 }
 

src/macros/mod.rs

@@ -151,9 +151,12 @@
 /// sqlx::query!("select $1::int4 as id", my_int as MyInt4)
 /// ```
 ///
-/// Using `expr as _` or `expr : _` simply signals to the macro to not type-check that bind expression,
-/// and then that syntax is stripped from the expression so as to not trigger type errors
-/// (or an unstable syntax feature in the case of the latter, which is called type ascription).
+/// Using `expr as _` simply signals to the macro to not type-check that bind expression,
+/// and then that syntax is stripped from the expression so as to not trigger type errors.
+///
+/// **NOTE:** type ascription syntax (`expr: _`) is deprecated and will be removed in a
+/// future release. This is due to Rust's [RFC 3307](https://github.com/rust-lang/rfcs/pull/3307)
+/// officially dropping support for the syntax.
 ///
 /// ## Type Overrides: Output Columns
 /// Type overrides are also available for output columns, utilizing the SQL standard's support