Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Fix function and unit testing bugs #478

Open
gsvidaurre opened this issue Jan 13, 2025 · 2 comments
Open

[R] Fix function and unit testing bugs #478

gsvidaurre opened this issue Jan 13, 2025 · 2 comments
Assignees
Labels
bug Something isn't working after the full integration started epic Parent big issue with children related

Comments

@gsvidaurre
Copy link
Collaborator

score_clusters() has hardcoded timezones argument values in different sections that need to be updated from "America/New York" to the value provided to the tz argument, or just "". Fixing the timezone argument so it accepts geographic/location information should be a future focus.

@gsvidaurre gsvidaurre added the bug Something isn't working after the full integration started label Jan 13, 2025
@gsvidaurre gsvidaurre self-assigned this Jan 13, 2025
@gsvidaurre
Copy link
Collaborator Author

gsvidaurre commented Feb 8, 2025

Originally issue #477: Fix the following in unit tests:

The path for unit testing needs to be generalized, ideally in the main script to run all unit tests
The code to install packages if they're not already installed should updated to:
is_installed <- function(p) is.element(p, installed.packages()[,1])

invisible(lapply(1:length(X), function(x){
if(!is_installed(X[x])){
install.packages(X[x], repos = "http://lib.stat.cmu.edu/R/CRAN")
}
}))

@gsvidaurre
Copy link
Collaborator Author

Also fix a bug in detect_perching_events(), in which the function fails to detect two empirical RFID detections around 1.5 seconds apart, even using thresholds of 1 or 2 seconds.

@gsvidaurre gsvidaurre added the epic Parent big issue with children related label Feb 8, 2025
@gsvidaurre gsvidaurre changed the title [R functions] timezone format in score_clusters() [R] Fix function and unit testing bugs Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working after the full integration started epic Parent big issue with children related
Projects
None yet
Development

No branches or pull requests

1 participant