Skip to content

Commit dde7f6c

Browse files
committed
cleaning up; fixed gemspec
1 parent 14dbe72 commit dde7f6c

File tree

3 files changed

+9
-56
lines changed

3 files changed

+9
-56
lines changed

lib/rails_sql_views/connection_adapters/postgresql_adapter.rb

+1-47
Original file line numberDiff line numberDiff line change
@@ -2,60 +2,14 @@ module RailsSqlViews
22
module ConnectionAdapters
33
module PostgreSQLAdapter
44
def self.included(base)
5-
puts "\nmy postgres self.included", self.to_s, base.to_s
6-
puts method_defined?(:tables), method_defined?(:tables_with_views_included)
7-
puts base.method_defined?(:tables), base.method_defined?(:tables_with_views_included)
8-
puts instance_methods.inspect, base.instance_methods.inspect
9-
10-
unless method_defined?(:tables_with_views_included)
11-
base.alias_method_chain :tables, :views_included
12-
else
13-
alias_method :tables, :tables_with_views_included # still doesn't run the right one, grump
14-
end
15-
base.alias_method_chain :table_exists?, :views_included
16-
17-
puts method_defined?(:tables_without_views_included)
18-
puts base.method_defined?(:tables_without_views_included)
19-
puts method_defined?(:table_exists_without_views_included?)
20-
puts base.method_defined?(:table_exists_without_views_included?)
5+
base.alias_method_chain :tables, :views_included unless method_defined?(:tables_with_views_included)
216
end
22-
23-
247
# Returns true as this adapter supports views.
258
def supports_views?
269
true
2710
end
2811

29-
def table_exists_with_views_included?(name)
30-
puts "\nmy postgres table_exists?", "name #{name}"
31-
name = name.to_s
32-
schema, table = name.split('.', 2)
33-
unless table # A table was provided without a schema
34-
table = schema
35-
schema = nil
36-
end
37-
if name =~ /^"/ # Handle quoted table names
38-
table = name
39-
schema = nil
40-
end
41-
puts "schema #{schema}", "table #{table}"
42-
43-
query(<<-SQL).first[0].to_i > 0
44-
SELECT COUNT(*)
45-
FROM (
46-
select schemaname, tablename as itemname
47-
from pg_tables
48-
union
49-
select schemaname, viewname
50-
from pg_views
51-
) combo
52-
WHERE itemname = '#{table.gsub(/(^"|"$)/,'')}'
53-
#{schema ? "AND schemaname = '#{schema}'" : ''}
54-
SQL
55-
end
56-
5712
def tables_with_views_included(name = nil)
58-
puts "\nmy postgres tables"
5913
q = <<-SQL
6014
SELECT table_name, table_type
6115
FROM information_schema.tables

lib/rails_sql_views/loader.rb

-4
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@ def self.load_extensions
77
SUPPORTED_ADAPTERS.each do |db|
88
if ActiveRecord::ConnectionAdapters.const_defined?("#{db}Adapter")
99
require "rails_sql_views/connection_adapters/#{db.downcase}_adapter"
10-
puts "\nload_extensions"
11-
klass = ActiveRecord::ConnectionAdapters.const_get("#{db}Adapter")
12-
puts klass.class.to_s, klass.to_s
13-
puts klass.class.method_defined?(:tables), klass.class.method_defined?(:tables_with_views_included)
1410
ActiveRecord::ConnectionAdapters.const_get("#{db}Adapter").class_eval do
1511
include RailsSqlViews::ConnectionAdapters::AbstractAdapter
1612
include RailsSqlViews::ConnectionAdapters.const_get("#{db}Adapter")

rails_sql_views.gemspec

+8-5
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55

66
Gem::Specification.new do |s|
77
s.name = %q{rails_sql_views}
8-
s.version = "0.8.0.1.laripk"
8+
s.version = "0.8.0.2.laripk"
99

1010
s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
1111
s.authors = ["Anthony Eden"]
12-
s.date = %q{2011-06-03}
12+
s.date = %q{2011-06-10}
1313
s.description = %q{Adds support for using SQL views within ActiveRecord}
1414
s.email = %q{[email protected]}
1515
s.extra_rdoc_files = [
@@ -53,10 +53,11 @@ Gem::Specification.new do |s|
5353
if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
5454
s.add_runtime_dependency(%q<rake>, ["= 0.8.7"])
5555
s.add_runtime_dependency(%q<rails>, ["~> 3.0.7"])
56-
s.add_runtime_dependency(%q<mysql2>, ["= 0.2.7"])
5756
s.add_development_dependency(%q<jeweler>, ["= 1.6.2"])
5857
s.add_development_dependency(%q<flexmock>, ["= 0.9.0"])
5958
s.add_development_dependency(%q<test-unit>, ["= 2.3.0"])
59+
s.add_development_dependency(%q<mysql2>, ["= 0.2.7"])
60+
s.add_development_dependency(%q<pg>, ["= 0.11.0"])
6061
s.add_runtime_dependency(%q<activerecord>, [">= 0"])
6162
s.add_development_dependency(%q<flexmock>, [">= 0"])
6263
s.add_development_dependency(%q<pg>, [">= 0"])
@@ -65,10 +66,11 @@ Gem::Specification.new do |s|
6566
else
6667
s.add_dependency(%q<rake>, ["= 0.8.7"])
6768
s.add_dependency(%q<rails>, ["~> 3.0.7"])
68-
s.add_dependency(%q<mysql2>, ["= 0.2.7"])
6969
s.add_dependency(%q<jeweler>, ["= 1.6.2"])
7070
s.add_dependency(%q<flexmock>, ["= 0.9.0"])
7171
s.add_dependency(%q<test-unit>, ["= 2.3.0"])
72+
s.add_dependency(%q<mysql2>, ["= 0.2.7"])
73+
s.add_dependency(%q<pg>, ["= 0.11.0"])
7274
s.add_dependency(%q<activerecord>, [">= 0"])
7375
s.add_dependency(%q<flexmock>, [">= 0"])
7476
s.add_dependency(%q<pg>, [">= 0"])
@@ -78,10 +80,11 @@ Gem::Specification.new do |s|
7880
else
7981
s.add_dependency(%q<rake>, ["= 0.8.7"])
8082
s.add_dependency(%q<rails>, ["~> 3.0.7"])
81-
s.add_dependency(%q<mysql2>, ["= 0.2.7"])
8283
s.add_dependency(%q<jeweler>, ["= 1.6.2"])
8384
s.add_dependency(%q<flexmock>, ["= 0.9.0"])
8485
s.add_dependency(%q<test-unit>, ["= 2.3.0"])
86+
s.add_dependency(%q<mysql2>, ["= 0.2.7"])
87+
s.add_dependency(%q<pg>, ["= 0.11.0"])
8588
s.add_dependency(%q<activerecord>, [">= 0"])
8689
s.add_dependency(%q<flexmock>, [">= 0"])
8790
s.add_dependency(%q<pg>, [">= 0"])

0 commit comments

Comments
 (0)