[5.x] Throw exception if config is incomplete (#736)

* Throw exception if config is incomplete

* rename method

* Update SocialiteManager.php

---------

Co-authored-by: Taylor Otwell <[email protected]>

Author: mateusjatenee

src/Exceptions/DriverMissingConfigurationException.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Laravel\Socialite\Exceptions;
+
+use InvalidArgumentException;
+
+class DriverMissingConfigurationException extends InvalidArgumentException
+{
+    /**
+     * Create a new exception for a missing configuration.
+     *
+     * @param  string  $provider
+     * @param  array<int, string>  $keys
+     * @return static
+     */
+    public static function make($provider, $keys)
+    {
+        return new static("Missing required configuration keys [" . implode(', ', $keys) . "] for [{$provider}] OAuth provider.");
+    }
+} 

src/SocialiteManager.php

@@ -6,6 +6,7 @@
 use Illuminate\Support\Manager;
 use Illuminate\Support\Str;
 use InvalidArgumentException;
+use Laravel\Socialite\Exceptions\DriverMissingConfigurationException;
 use Laravel\Socialite\One\TwitterProvider;
 use Laravel\Socialite\Two\BitbucketProvider;
 use Laravel\Socialite\Two\FacebookProvider;
@@ -238,6 +239,14 @@ protected function createSlackOpenidDriver()
      */
     public function buildProvider($provider, $config)
     {
+        $requiredKeys = ['client_id', 'client_secret', 'redirect'];
+
+        $missingKeys = array_diff($requiredKeys, array_keys($config ?? []));
+
+        if (! empty($missingKeys)) {
+            throw DriverMissingConfigurationException::make($provider, $missingKeys);
+        }
+
         return (new $provider(
             $this->container->make('request'), $config['client_id'],
             $config['client_secret'], $this->formatRedirectUrl($config),

tests/SocialiteManagerTest.php

@@ -3,6 +3,7 @@
 namespace Laravel\Socialite\Tests;
 
 use Laravel\Socialite\Contracts\Factory;
+use Laravel\Socialite\Exceptions\DriverMissingConfigurationException;
 use Laravel\Socialite\SocialiteServiceProvider;
 use Laravel\Socialite\Two\GithubProvider;
 use Orchestra\Testbench\TestCase;
@@ -77,4 +78,61 @@ public function test_it_can_instantiate_the_github_driver_with_scopes_from_confi
         $provider = $factory->driver('github')->setScopes(['read:user']);
         $this->assertSame(['read:user'], $provider->getScopes());
     }
+
+    public function test_it_throws_exception_when_client_secret_is_missing()
+    {
+        $this->expectException(DriverMissingConfigurationException::class);
+        $this->expectExceptionMessage('Missing required configuration keys [client_secret] for [Laravel\Socialite\Two\GithubProvider] OAuth provider.');
+
+        $factory = $this->app->make(Factory::class);
+
+        $this->app['config']->set('services.github', [
+            'client_id' => 'github-client-id',
+            'redirect' => 'http://your-callback-url',
+        ]);
+        
+        $factory->driver('github');
+    }
+
+    public function test_it_throws_exception_when_client_id_is_missing()
+    {
+        $this->expectException(DriverMissingConfigurationException::class);
+        $this->expectExceptionMessage('Missing required configuration keys [client_id] for [Laravel\Socialite\Two\GithubProvider] OAuth provider.');
+
+        $factory = $this->app->make(Factory::class);
+
+        $this->app['config']->set('services.github', [
+            'client_secret' => 'github-client-secret',
+            'redirect' => 'http://your-callback-url',
+        ]);
+
+        $factory->driver('github');
+    }
+
+    public function test_it_throws_exception_when_redirect_is_missing()
+    {
+        $this->expectException(DriverMissingConfigurationException::class);
+        $this->expectExceptionMessage('Missing required configuration keys [redirect] for [Laravel\Socialite\Two\GithubProvider] OAuth provider.');
+
+        $factory = $this->app->make(Factory::class);
+
+        $this->app['config']->set('services.github', [
+            'client_id' => 'github-client-id',
+            'client_secret' => 'github-client-secret',
+        ]);
+
+        $factory->driver('github');
+    }
+
+    public function test_it_throws_exception_when_configuration_is_completely_missing()
+    {
+        $this->expectException(DriverMissingConfigurationException::class);
+        $this->expectExceptionMessage('Missing required configuration keys [client_id, client_secret, redirect] for [Laravel\Socialite\Two\GithubProvider] OAuth provider.');
+
+        $factory = $this->app->make(Factory::class);
+
+        $this->app['config']->set('services.github', null);
+
+        $factory->driver('github');
+    }
 }