Field::show() and Field::hide() to support optional callback

[magdicom]

Currently I have write it this way:

if ($formData->type == "something"){
    $field->show();
}
else {
    $field->hide();
}

it would be much better if show method accepts a value or callback, this way I would wrote it this way instead:

$field->show($formData->type == "something");

[magdicom]

for the moment I will be using $field->visible = ($formData->type == "something");!

[crynobone]

Hi there,

Both method was added to be used with dependsOn and the logic should already be applied before triggering the toggle between the two.

Or, you can just add macros for such usage.

Field::macro('showWhen', function ($condition) {
    if ($condition === true) {
        $this->show();
    } else {
        $this->hide();
    }
});

Field::macro('showUnless', function ($condition) {
    if ($condition === true) {
        $this->hide();
    } else {
        $this->show();
    }
});

[crynobone]

I have no idea how calling macros would trigger FieldCollection. It doesn't work that way by default.

[magdicom]

I have no idea how calling macros would trigger FieldCollection. It doesn't work that way by default.

I'm adding macro to this class Laravel\Nova\Fields\Field.

do you have any idea?

[crynobone]

Unable to replicate that issue.

[crynobone]

Please remove the repository (before we submit GitHub DMCA Takedown), you are never allowed to publish Nova code without permission.

[magdicom]

@crynobone wasn't intentional, all I was thinking is to reproduce the issue for you to see!

[magdicom]

if anyone ended up here, this works:

Field::macro('showWhen', function ($condition) {
    if ($condition === true) {
        $this->show();
    } else {
        $this->hide();
    }
    return $this;
});

Field::macro('showUnless', function ($condition) {
    if ($condition === true) {
        $this->hide();
    } else {
        $this->show();
    }
    return $this;
});