[Refactor] Adjust implementation for allowing zero as a resource id

Author: lindyhopchris

CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file. This project adheres to
 [Semantic Versioning](http://semver.org/) and [this changelog format](http://keepachangelog.com/).
 
+## Unreleased
+
+### Fixed
+
+- [#178](https://github.com/laravel-json-api/laravel/issues/178) Allow a resource id that is `"0"`.
+
 ## [2.1.0] - 2022-02-20
 
 ### Added

composer.json

@@ -25,11 +25,11 @@
     "require": {
         "php": "^7.4|^8.0",
         "ext-json": "*",
-        "laravel-json-api/core": "^2.1",
+        "laravel-json-api/core": "^2.2",
         "laravel-json-api/eloquent": "^2.1",
         "laravel-json-api/encoder-neomerx": "^2.0",
         "laravel-json-api/exceptions": "^1.1",
-        "laravel-json-api/spec": "^1.1",
+        "laravel-json-api/spec": "^1.1.1",
         "laravel-json-api/validation": "^2.0",
         "laravel/framework": "^8.76|^9.0"
     },

src/Routing/Route.php

@@ -27,6 +27,7 @@
 use LaravelJsonApi\Contracts\Schema\Relation;
 use LaravelJsonApi\Contracts\Schema\Schema;
 use LaravelJsonApi\Contracts\Server\Server;
+use LaravelJsonApi\Core\Document\ResourceIdentifier;
 use LogicException;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
@@ -101,11 +102,11 @@ public function modelOrResourceId()
 
         $modelOrResourceId = $this->route->parameter($name);
 
-        if (!empty($modelOrResourceId) || '0' === $modelOrResourceId) {
-            return $modelOrResourceId;
+        if (!is_object($modelOrResourceId) && ResourceIdentifier::idIsEmpty($modelOrResourceId)) {
+            throw new LogicException('No JSON API resource id set on route.');
         }
 
-        throw new LogicException('No JSON API resource id set on route.');
+        return $modelOrResourceId;
     }
 
     /**