feat: #22 pmd

Author: shaunthegeek

README.md

@@ -25,7 +25,9 @@ php artisan lint:publish
 php artisan lint:code
 php artisan lint:code --fix
 php artisan lint:code app/ tests/
-php artisan lint:code --standard=Squiz app/
+php artisan lint:code app/ tests/ --fix
+php artisan lint:phpcs
+php artisan lint:pmd
 php artisan lint:staged
 ```
 

composer.json

@@ -35,6 +35,7 @@
         "squizlabs/php_codesniffer": ">=3.5"
     },
     "require-dev": {
-        "orchestra/testbench": ">=v7"
+        "orchestra/testbench": ">=v7",
+        "php-mock/php-mock": "^2.5"
     }
 }

src/LintCodeCommand.php

@@ -15,8 +15,7 @@ class LintCodeCommand extends Command
      */
     protected $signature = 'lint:code
         {files?*}
-        {--fix : automatic fix}
-        {--standard=phpcs.xml : coding standards}';
+        {--fix : automatic fix}';
 
     /**
      * The console command description.
@@ -32,17 +31,12 @@ class LintCodeCommand extends Command
      */
     public function handle()
     {
-        $bin = $this->option('fix') ? 'phpcbf' : 'phpcs';
-        $files = empty($this->argument('files')) ? ['.'] : $this->argument('files');
-        $command = "vendor" . DIRECTORY_SEPARATOR . "bin" . DIRECTORY_SEPARATOR . "$bin --standard=";
-        exec(
-            $command . $this->option('standard') . ' ' . implode(' ', $files),
-            $output,
-            $code
-        );
-        foreach ($output as $line) {
-            $this->line($line);
-        }
+        $code = $this->call('lint:phpcs', [
+            'files' => $this->argument('files'), '--fix' => $this->option('fix')
+        ]);
+        $code += $this->call('lint:phpmd', [
+            'files' => $this->argument('files')
+        ]);
         return $code;
     }
 }

src/LintPhpcsCommand.php

@@ -0,0 +1,48 @@
+<?php
+
+namespace LaravelFans\Lint;
+
+use FilesystemIterator;
+use Illuminate\Console\Command;
+use Illuminate\Support\Facades\File;
+
+class LintPhpcsCommand extends Command
+{
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'lint:phpcs
+        {--fix : automatic fix}
+        {--standard=phpcs.xml : coding standards}
+        {files?*}';
+
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Lint by phpcs';
+
+    /**
+     * Execute the console command.
+     *
+     * @return void
+     */
+    public function handle()
+    {
+        $bin = $this->option('fix') ? 'phpcbf' : 'phpcs';
+        $files = empty($this->argument('files')) ? ['.'] : $this->argument('files');
+        $command = "vendor" . DIRECTORY_SEPARATOR . "bin" . DIRECTORY_SEPARATOR . "$bin --standard=";
+        exec(
+            $command . $this->option('standard') . ' ' . implode(' ', $files),
+            $output,
+            $code
+        );
+        foreach ($output as $line) {
+            $this->line($line);
+        }
+        return $code;
+    }
+}

src/LintPmdCommand.php

@@ -0,0 +1,47 @@
+<?php
+
+namespace LaravelFans\Lint;
+
+use FilesystemIterator;
+use Illuminate\Console\Command;
+use Illuminate\Support\Facades\File;
+
+class LintPmdCommand extends Command
+{
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'lint:pmd
+        {files?*}
+        {--format=text}
+        {--ruleset=phpmd.xml}';
+
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Lint by phpmd';
+
+    /**
+     * Execute the console command.
+     *
+     * @return void
+     */
+    public function handle()
+    {
+        $files = empty($this->argument('files')) ? ['.'] : $this->argument('files');
+        $command = "vendor" . DIRECTORY_SEPARATOR . "bin" . DIRECTORY_SEPARATOR . "phpmd ";
+        exec(
+            $command . implode(' ', $files) . ' ' . $this->option('format') . ' ' . $this->option('ruleset'),
+            $output,
+            $code
+        );
+        foreach ($output as $line) {
+            $this->line($line);
+        }
+        return $code;
+    }
+}

src/LintServiceProvider.php

@@ -16,6 +16,8 @@ public function boot()
         if ($this->app->runningInConsole()) {
             $this->commands([
                 LintCodeCommand::class,
+                LintPmdCommand::class,
+                LintPhpcsCommand::class,
                 LintPublishCommand::class,
                 LintRouteCommand::class,
                 LintStagedCommand::class,

tests/LintPhpcsCommandTest.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace LaravelFans\Lint\Tests;
+
+use Illuminate\Support\Facades\File;
+use phpmock\MockBuilder;
+use phpmock\functions\FixedValueFunction;
+
+class LintPhpcsCommandTest extends TestCase
+{
+    public function testLintPhpcsWithoutArgs()
+    {
+        $builder = new MockBuilder();
+        $builder->setNamespace('\\LaravelFans\\Lint')
+            ->setName("exec")
+            ->setFunction(
+                function ($command, &$output, &$code) {
+                    $this->assertEquals("vendor/bin/phpcs --standard=phpcs.xml .", $command);
+                    $output = [];
+                    $code = 0;
+                }
+            );
+        $mock = $builder->build();
+        $mock->enable();
+        $this->artisan('lint:phpcs')->assertExitCode(0);
+        $mock->disable();
+    }
+}

tests/LintPmdCommandTest.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace LaravelFans\Lint\Tests;
+
+use Illuminate\Support\Facades\File;
+use phpmock\MockBuilder;
+use phpmock\functions\FixedValueFunction;
+
+class LintPmdCommandTest extends TestCase
+{
+    public function testLintPmdWithoutArgs()
+    {
+        $builder = new MockBuilder();
+        $builder->setNamespace('\\LaravelFans\\Lint')
+            ->setName("exec")
+            ->setFunction(
+                function ($command, &$output, &$code) {
+                    $this->assertEquals("vendor/bin/phpmd . text phpmd.xml", $command);
+                    $output = [];
+                    $code = 1;
+                }
+            );
+        $mock = $builder->build();
+        $mock->enable();
+        $this->artisan('lint:pmd')->assertExitCode(1);
+        $mock->disable();
+    }
+}