Skip to content

Commit 3fef797

Browse files
committed
updates for php8; creates missing folders for attachables
1 parent c4a27cd commit 3fef797

File tree

14 files changed

+42
-130
lines changed

14 files changed

+42
-130
lines changed

composer.json

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,16 @@
1010
"homepage": "https://github.com/laravel-enso/files",
1111
"type": "library",
1212
"license": "MIT",
13-
"authors": [{
14-
"name": "Adrian Ocneanu",
15-
"email": "[email protected]",
16-
"homepage": "https://laravel-enso.com",
17-
"role": "Developer"
18-
}],
13+
"authors": [
14+
{
15+
"name": "Adrian Ocneanu",
16+
"email": "[email protected]",
17+
"homepage": "https://laravel-enso.com",
18+
"role": "Developer"
19+
}
20+
],
1921
"require": {
20-
"php": ">=7.4.0",
21-
"laravel-enso/core": "^5.0|^6.0",
22+
"laravel-enso/core": "^7.0",
2223
"laravel-enso/helpers": "^2.0",
2324
"laravel-enso/image-transformer": "^2.0",
2425
"laravel-enso/migrator": "^2.0",
@@ -42,4 +43,4 @@
4243
}
4344
}
4445
}
45-
}
46+
}

config/files.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22

33
return [
4-
'linkExpiration' => env('TEMPORARY_LINK_EXPIRATION', 60 * 60 * 24),
4+
'linkExpiration' => (int) env('TEMPORARY_LINK_EXPIRATION', 60 * 60 * 24),
55
'storageLimit' => 500000,
66
'paginate' => (int) env('FILES_PAGINATION', 24),
77
'testingFolder' => 'testing',

routes/api.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
->prefix('api/core')
88
->as('core.')
99
->group(function () {
10-
require 'app/files.php';
11-
require 'app/uploads.php';
10+
require __DIR__.'/app/files.php';
11+
require __DIR__.'/app/uploads.php';
1212
});
1313

1414
Route::middleware(['signed', 'bindings'])

src/Contracts/AuthorizesFileAccess.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace LaravelEnso\Files\Contracts;
44

5-
use LaravelEnso\Core\Models\User;
5+
use LaravelEnso\Users\Models\User;
66

77
interface AuthorizesFileAccess
88
{

src/Models/File.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313
use Illuminate\Support\Facades\URL;
1414
use Illuminate\Support\Facades\Validator;
1515
use Illuminate\Support\Str;
16-
use LaravelEnso\Core\Models\User;
1716
use LaravelEnso\Files\Exceptions\File as Exception;
1817
use LaravelEnso\Files\Facades\FileBrowser;
1918
use LaravelEnso\Files\Services\FileValidator;
2019
use LaravelEnso\Files\Services\ImageProcessor;
2120
use LaravelEnso\Files\Traits\FilePolicies;
2221
use LaravelEnso\ImageTransformer\Services\ImageTransformer;
2322
use LaravelEnso\TrackWho\Traits\CreatedBy;
23+
use LaravelEnso\Users\Models\User;
2424
use Symfony\Component\HttpFoundation\File\File as BaseFile;
2525
use Symfony\Component\HttpFoundation\StreamedResponse;
2626

src/Policies/File.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
namespace LaravelEnso\Files\Policies;
44

55
use Illuminate\Auth\Access\HandlesAuthorization;
6-
use LaravelEnso\Core\Models\User;
76
use LaravelEnso\Files\Contracts\AuthorizesFileAccess;
87
use LaravelEnso\Files\Models\File as Model;
8+
use LaravelEnso\Users\Models\User;
99

1010
class File
1111
{

src/Policies/Upload.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
namespace LaravelEnso\Files\Policies;
44

55
use Illuminate\Auth\Access\HandlesAuthorization;
6-
use LaravelEnso\Core\Models\User;
76
use LaravelEnso\Files\Models\Upload as Model;
7+
use LaravelEnso\Users\Models\User;
88

99
class Upload
1010
{

src/Services/FileBrowser.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function model($folder): ?string
4242

4343
public function remove($folders): void
4444
{
45-
(new Collection($folders))
45+
Collection::wrap($folders)
4646
->each(fn ($folder) => $this->models->forget($folder));
4747
}
4848

src/Services/FileValidator.php

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,11 @@
1010

1111
class FileValidator
1212
{
13-
protected BaseFile $file;
14-
15-
private array $extensions;
16-
private array $mimeTypes;
17-
18-
public function __construct(BaseFile $file, array $extensions, array $mimeTypes)
19-
{
20-
$this->file = $file;
21-
$this->extensions = $extensions;
22-
$this->mimeTypes = $mimeTypes;
13+
public function __construct(
14+
protected BaseFile $file,
15+
private array $extensions,
16+
private array $mimeTypes
17+
) {
2318
}
2419

2520
public function handle(): void
@@ -40,33 +35,29 @@ private function validateFile(): self
4035

4136
private function validateExtension(): self
4237
{
43-
$valid = (new Collection($this->extensions));
38+
$valid = new Collection($this->extensions);
4439

4540
$extension = $this->file instanceof UploadedFile
4641
? $this->file->getClientOriginalExtension()
4742
: $this->file->getExtension();
4843

4944
if ($valid->isNotEmpty() && ! $valid->contains($extension)) {
50-
throw FileException::invalidExtension(
51-
$extension,
52-
implode(', ', $this->extensions)
53-
);
45+
$extensions = implode(', ', $this->extensions);
46+
throw FileException::invalidExtension($extension, $extensions);
5447
}
5548

5649
return $this;
5750
}
5851

5952
private function validateMimeType()
6053
{
61-
$valid = (new Collection($this->mimeTypes));
54+
$valid = new Collection($this->mimeTypes);
6255

6356
$mimeType = $this->file->getMimeType();
6457

6558
if ($valid->isNotEmpty() && ! $valid->contains($mimeType)) {
66-
throw FileException::invalidMimeType(
67-
$mimeType,
68-
implode(', ', $this->mimeTypes),
69-
);
59+
$mimeTypes = implode(', ', $this->mimeTypes);
60+
throw FileException::invalidMimeType($mimeType, $mimeTypes);
7061
}
7162

7263
return $this;

src/Services/ImageProcessor.php

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,13 @@
88

99
class ImageProcessor
1010
{
11-
private File $file;
12-
private bool $optimize;
13-
private array $resize;
1411
private ImageTransformer $transformer;
1512

16-
public function __construct(File $file, bool $optimize, array $resize)
17-
{
18-
$this->file = $file;
19-
$this->optimize = $optimize;
20-
$this->resize = $resize;
13+
public function __construct(
14+
private File $file,
15+
private bool $optimize,
16+
private array $resize
17+
) {
2118
}
2219

2320
public function handle(): void

0 commit comments

Comments
 (0)