Skip to content

Commit da0efdb

Browse files
authored
Remove forgotten fragments of pip_import rule. (bazel-contrib#588)
1 parent 1152bd1 commit da0efdb

File tree

6 files changed

+1
-138
lines changed

6 files changed

+1
-138
lines changed

.github/CODEOWNERS

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
/python/ @brandjon @lberki
88
# But not everything under python/ is the core Python rules.
99
/python/pip.bzl @thundergolfer @andyscott
10-
/python/whl.bzl @thundergolfer @andyscott
1110
/python/requirements.txt @thundergolfer @andyscott
1211

1312
# Directory containing the Gazelle extension and Go code.

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ fully migrated to Starlark code.
6262

6363
Practically, this means that a Bazel team member should approve any PR
6464
concerning the core Python logic. This includes everything under the `python/`
65-
directory except for `pip.bzl`, `whl.bzl`, and `requirements.txt`.
65+
directory except for `pip.bzl` and `requirements.txt`.
6666

6767
Issues should be triaged as follows:
6868

docs/BUILD

-11
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ _DOCS = {
2525
"packaging": "//docs:packaging-docs",
2626
"pip": "//docs:pip-docs",
2727
"python": "//docs:core-docs",
28-
"whl": "//docs:whl-docs",
2928
}
3029

3130
# We define these bzl_library targets here rather than in the //python package
@@ -86,10 +85,6 @@ stardoc(
8685
deps = [":defs"],
8786
)
8887

89-
# TODO: Consider merging documentation pages for whl and pip. This would
90-
# require re-exporting their symbols from a common .bzl; see
91-
# https://github.com/bazelbuild/skydoc/issues/208.
92-
9388
stardoc(
9489
name = "pip-docs",
9590
out = "pip.md_",
@@ -101,12 +96,6 @@ stardoc(
10196
],
10297
)
10398

104-
stardoc(
105-
name = "whl-docs",
106-
out = "whl.md_",
107-
input = "//python:whl.bzl",
108-
)
109-
11099
stardoc(
111100
name = "packaging-docs",
112101
out = "packaging.md_",

docs/whl.md

-40
This file was deleted.

python/BUILD

-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ filegroup(
4646
"defs.bzl",
4747
"packaging.bzl",
4848
"pip.bzl",
49-
"whl.bzl",
5049
"//python/private:bzl",
5150
],
5251
visibility = ["//:__pkg__"],
@@ -135,5 +134,4 @@ alias(
135134
exports_files([
136135
"packaging.bzl",
137136
"pip.bzl",
138-
"whl.bzl",
139137
])

python/whl.bzl

-83
This file was deleted.

0 commit comments

Comments
 (0)