Deleted legacy pip_import rule (bazel-contrib#582)

Author: UebelAndre

.bazelrc

@@ -3,8 +3,8 @@
 # This lets us glob() up all the files inside the examples to make them inputs to tests
 # (Note, we cannot use `common --deleted_packages` because the bazel version command doesn't support it)
 # To update these lines, run tools/bazel_integration_test/update_deleted_packages.sh
-build --deleted_packages=examples/build_file_generation,examples/legacy_pip_import/boto,examples/legacy_pip_import/extras,examples/legacy_pip_import/helloworld,examples/pip_install,examples/pip_parse,examples/py_import,examples/relative_requirements
-query --deleted_packages=examples/build_file_generation,examples/legacy_pip_import/boto,examples/legacy_pip_import/extras,examples/legacy_pip_import/helloworld,examples/pip_install,examples/pip_parse,examples/py_import,examples/relative_requirements
+build --deleted_packages=examples/build_file_generation,examples/pip_install,examples/pip_parse,examples/py_import,examples/relative_requirements
+query --deleted_packages=examples/build_file_generation,examples/pip_install,examples/pip_parse,examples/py_import,examples/relative_requirements
 
 test --test_output=errors
 

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,7 +2,6 @@
 
 Please check if your PR fulfills the following requirements:
 
-- [ ] Does not include precompiled binaries, eg. `.par` files. See [CONTRIBUTING.md](https://github.com/bazelbuild/rules_python/blob/master/CONTRIBUTING.md) for info
 - [ ] Tests for the changes have been added (for bug fixes / features)
 - [ ] Docs have been added / updated (for bug fixes / features)
 

.gitignore

@@ -37,6 +37,7 @@
 /bazel-genfiles
 /bazel-out
 /bazel-testlogs
+user.bazelrc
 
 # vim swap files
 *.swp
@@ -45,4 +46,4 @@
 # Go/Gazelle files
 # These otherwise match patterns above
 !go.mod
-!BUILD.out
+!BUILD.out

CONTRIBUTING.md

@@ -52,28 +52,6 @@ bazel run //docs:update
 This needs to be done whenever the docstrings in the corresponding .bzl files
 are changed; a test failure will remind you to run this command when needed.
 
-### Precompiled tools
-
-The packaging rules depend on two precompiled binaries, `tools/piptool.par` and
-`tools/whltool.par`. We need these to be precompiled because they are invoked
-during `WORKSPACE` evaluation, before Bazel itself is able to build anything
-from source. The .par files can be regenerated by running this script in the
-repository root:
-
-```shell
-# You can pass --nodocker if Docker is not available on your system.
-./update_tools.sh
-```
-
-This needs to be done whenever the corresponding sources in the `packaging/`
-directory are updated.
-
-Since these are binary files and therefore unreviewable, for security
-reasons<sup>1</sup> we will regenerate the .par files for you when merging your
-pull request.
-
-<sup>1</sup> See "[Reflections on Trusting Trust](https://en.wikipedia.org/wiki/Backdoor_(computing)#Compiler_backdoors)".
-
 ## Core rules
 
 The bulk of this repo is owned and maintained by the Bazel Python community.

README.md

@@ -154,27 +154,6 @@ load("@my_deps//:requirements.bzl", "install_deps")
 install_deps()
 ```
 
-### Importing `pip` dependencies with `pip_import` (legacy)
-
-The deprecated `pip_import` can still be used if needed. It is the only packaging rule that supports Python 2,
-which has been [sunsetted since January 1st, 2020](https://www.python.org/doc/sunset-python-2/). 
-
-```
-load("@rules_python//python/legacy_pip_import:pip.bzl", "pip_import", "pip_repositories")
-
-# Create a central repo that knows about the dependencies needed for requirements.txt.
-pip_import(
-   name = "my_deps",
-   requirements = "//path/to:requirements.txt",
-)
-
-# Load the central repo's install function from its `//:requirements.bzl` file, and call it.
-load("@my_deps//:requirements.bzl", "pip_install")
-pip_install()
-```
-
-An example can be found in [`examples/legacy_pip_import`](examples/legacy_pip_import).
-
 ### Consuming `pip` dependencies
 
 Each extracted wheel repo contains a `py_library` target representing the

docs/pip.md

@@ -35,24 +35,6 @@ It also generates two targets for running pip-compile:
 | kwargs |  other bazel attributes passed to the "_test" rule   |  none |
 
 
-<a name="#pip_import"></a>
-
-## pip_import
-
-<pre>
-pip_import(<a href="#pip_import-kwargs">kwargs</a>)
-</pre>
-
-    Rule for installing packages listed in a requirements file.
-
-**PARAMETERS**
-
-
-| Name  | Description | Default Value |
-| :-------------: | :-------------: | :-------------: |
-| kwargs |  <p align="center"> - </p>   |  none |
-
-
 <a name="#pip_install"></a>
 
 ## pip_install

examples/BUILD

@@ -17,11 +17,6 @@ package(default_visibility = ["//visibility:public"])
 
 licenses(["notice"])  # Apache 2.0
 
-bazel_integration_test(
-    name = "legacy_pip_import_example",
-    timeout = "long",
-)
-
 bazel_integration_test(
     name = "pip_install_example",
     timeout = "long",

examples/legacy_pip_import/.bazelrc

@@ -1 +1,2 @@
-test --test_output=errors
+# https://docs.bazel.build/versions/main/best-practices.html#using-the-bazelrc-file
+try-import %workspace%/user.bazelrc

examples/legacy_pip_import/README.md

@@ -0,0 +1,2 @@
+# https://docs.bazel.build/versions/main/best-practices.html#using-the-bazelrc-file
+try-import %workspace%/user.bazelrc

examples/legacy_pip_import/WORKSPACE

@@ -1,9 +1,7 @@
 """Dependencies that are needed for rules_python tests and tools."""
 
-load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive", "http_file")
 load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
-load("@rules_python//python/legacy_pip_import:pip.bzl", "pip_import")
 
 def rules_python_internal_deps():
     """Fetches all required dependencies for rules_python tests and tools."""
@@ -120,21 +118,6 @@ def rules_python_internal_deps():
         ],
     )
 
-    maybe(
-        git_repository,
-        name = "subpar",
-        remote = "https://github.com/google/subpar",
-        # tag = "2.0.0",
-        commit = "35bb9f0092f71ea56b742a520602da9b3638a24f",
-        shallow_since = "1557863961 -0400",
-    )
-
-    maybe(
-        pip_import,
-        name = "piptool_deps",
-        requirements = "@rules_python//python:requirements.txt",
-    )
-
     maybe(
         http_archive,
         name = "build_bazel_integration_testing",

examples/legacy_pip_import/boto/BUILD

@@ -3,22 +3,13 @@
 load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
 load("@build_bazel_integration_testing//tools:repositories.bzl", "bazel_binaries")
 load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
-
-# Requirements for building our piptool.
-load(
-    "@piptool_deps//:requirements.bzl",
-    _piptool_install = "pip_install",
-)
 load("//:version.bzl", "SUPPORTED_BAZEL_VERSIONS")
 load("//gazelle:deps.bzl", _go_repositories = "gazelle_deps")
 load("//python/pip_install:repositories.bzl", "pip_install_dependencies")
 
 def rules_python_internal_setup():
     """Setup for rules_python tests and tools."""
 
-    # Requirements for building our piptool.
-    _piptool_install()
-
     # Because we don't use the pip_install rule, we have to call this to fetch its deps
     pip_install_dependencies()