Skip to content

Commit 4ca3316

Browse files
committed
Fix canvas size for Android
1 parent 76151c0 commit 4ca3316

File tree

3 files changed

+17
-16
lines changed

3 files changed

+17
-16
lines changed

Android/MMEAndroid/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ buildscript {
88

99
}
1010
dependencies {
11-
classpath 'com.android.tools.build:gradle:4.0.0'
11+
classpath 'com.android.tools.build:gradle:4.0.1'
1212
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
1313
classpath 'com.google.gms:google-services:4.3.3'
1414
}

www/mappingScreen.js

+5-7
Original file line numberDiff line numberDiff line change
@@ -13,24 +13,24 @@ var canvas = {
1313
// ---------------------------------------------------------------------
1414

1515
// Set up canvas according to current window size
16-
setupCanvas = function() {
16+
setupCanvas = function(w, h) {
1717

1818
canvas[uistate.activeCanvas] = new fabric.Canvas(uistate.activeCanvas, {
19-
width: $(window).width(),
20-
height: $(window).height()
19+
width: w,
20+
height: h
2121
});
2222
canvas[uistate.activeCanvas].on("mouse:down", onCanvasClicked);
2323
canvas[uistate.activeCanvas].selection = false;
2424
canvas[uistate.activeCanvas].hoverCursor = "default";
2525
};
2626

2727
// Layout and behaviour of drawing screen
28-
setupMapping = function(mappingType) {
28+
setupMapping = function(mappingType, w, h) {
2929
console.log("Setting up: " + mappingType);
3030
console.log("Use mappings: " + settings.useMappings);
3131

3232
if (!canvas[uistate.activeCanvas]) { // using new fabric canvas is not possible
33-
setupCanvas();
33+
setupCanvas(w, h);
3434
}
3535
canvas[uistate.activeCanvas].clear();
3636

@@ -39,8 +39,6 @@ setupMapping = function(mappingType) {
3939
var fixedFactor = factors.fixed;
4040

4141
// Adjust Sizes
42-
var h = $(window).height();
43-
var w = $(window).width();
4442
canvasStyle = getPixelSizes(w, h, mappingType, settings);
4543

4644
// Set up arrows and factors

www/tool.js

+11-8
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ displayThankYouScreen = function() {
120120

121121

122122
// Prepare and show mapping screen
123-
displayMapping = function(mappingState) {
123+
displayMapping = function(mappingState, w, h) {
124124

125125
uistate.session.state = mappingState;
126126

@@ -152,7 +152,7 @@ displayMapping = function(mappingState) {
152152
console.log("Start mapping: " + mappingType);
153153
if (!canvas[uistate.activeCanvas]) {
154154
startSession(mappingType);
155-
setupMapping(mappingType);
155+
setupMapping(mappingType, w, h);
156156
}
157157

158158
resetUIstate();
@@ -204,15 +204,18 @@ leaveAndSaveSettings = function() {
204204
// Behaviour on start up
205205
window.onload = function() {
206206

207+
w = window.innerWidth;
208+
h = window.innerHeight;
209+
207210
$("#video")[0].src = "video/" + settings.introductionVideo;
208211
$("#audio")[0].src = "audio/" + settings.mappingAudioConsequences;
209212

210213
$("#video").on("ended", function() {
211214
var nextState = nextSessionState();
212215
switch (uistate.session.state) {
213-
case State.introduction: displayMapping(nextState); break;
214-
case State.driversInstructions: displayMapping(nextState); break;
215-
case State.consequencesInstructions: displayMapping(nextState); break;
216+
case State.introduction: displayMapping(nextState, w, h); break;
217+
case State.driversInstructions: displayMapping(nextState, w, h); break;
218+
case State.consequencesInstructions: displayMapping(nextState, w, h); break;
216219
default: console.log("Unknown or non-video session state: ", uistate.session.state);
217220
}
218221
});
@@ -226,19 +229,19 @@ window.onload = function() {
226229
displayVideo(State.introduction);
227230
});
228231
$("#btn-practice").on("click", function() {
229-
displayMapping(State.practiceMapping);
232+
displayMapping(State.practiceMapping, w, h);
230233
});
231234
$("#btn-instructions-drivers").on("click", function() {
232235
displayVideo(State.driversInstructions);
233236
});
234237
$("#btn-mapping-drivers").on("click", function() {
235-
displayMapping(State.driversMapping);
238+
displayMapping(State.driversMapping, w, h);
236239
});
237240
$("#btn-instructions-consequences").on("click", function() {
238241
displayVideo(State.consequencesInstructions);
239242
});
240243
$("#btn-mapping-consequences").on("click", function() {
241-
displayMapping(State.consequencesMapping);
244+
displayMapping(State.consequencesMapping, w, h);
242245
});
243246
$("#btn-download").on("click", downloadData);
244247
$("#btn-settings").on("click", displaySettings);

0 commit comments

Comments
 (0)