Skip to content

Commit e7d2c7e

Browse files
committed
refactor approval stage workflow
1 parent 5b91fb2 commit e7d2c7e

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

.github/workflows/main.yml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,24 +101,18 @@ jobs:
101101
name: Waiting for approval
102102
runs-on: ubuntu-latest
103103
steps:
104-
- name: Generate token
105-
id: generate_token
106-
uses: tibdex/github-app-token@v1
107-
with:
108-
app_id: ${{ secrets.APP_ID }}
109-
private_key: ${{ secrets.APP_SECRET }}
110104
- name: Approve Production Deployment
111105
uses: trstringer/manual-approval@v1
112106
with:
113-
approvers: approvers
107+
approvers: approvers # lambda feedback defined team in organisation
114108
minimum-approvals: 1
115109
timeout-minutes: 10
116-
secret: ${{ steps.generate_token.outputs.token }}
110+
secret: ${{ secrets.GITHUB_TOKEN }}
117111
issue-title: Approve Production Deployment
118112
issue-body: Approve production deployment for the Chatbot Module
119113
exclude-workflow-initiator-as-approver: false
120-
additional-approved-words: fine, go
121-
additional-denied-words: ""
114+
additional-approved-words: "fine, go ahead"
115+
additional-denied-words: "deny, to review"
122116

123117
prod_job:
124118
needs: approval_job
@@ -138,6 +132,7 @@ jobs:
138132
- name: Login to Amazon ECR
139133
id: login-pf-aws-ecr
140134
uses: aws-actions/amazon-ecr-login@v2
135+
141136
- name: Build and push the tagged docker image to Amazon ECR
142137
id: build-custom-image
143138
env:

0 commit comments

Comments
 (0)