Skip to content

Commit 19e8f5e

Browse files
committed
Switched endpoint to be a secret
1 parent 66511d9 commit 19e8f5e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/deploy.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ on:
8080
gcp_credentials:
8181
description: "The JSON key for deploying to GCP"
8282
required: false
83+
TEST_API_ENDPOINT:
84+
description: "The staging evaluation function to use to test against the database"
85+
required: false
8386
DB_USER:
8487
description: "Database User for fetching test data"
8588
required: false
@@ -98,7 +101,6 @@ on:
98101

99102
jobs:
100103
setup:
101-
# ... (setup job remains unchanged) ...
102104
name: Setup
103105
runs-on: ubuntu-latest
104106
outputs:
@@ -176,7 +178,6 @@ jobs:
176178
fi
177179
178180
deploy-staging:
179-
# ... (deploy-staging job remains unchanged) ...
180181
if: ${{inputs.environment == 'staging' || inputs.environment == 'production'}}
181182
uses: ./.github/workflows/staging_deploy.yml
182183
needs: setup
@@ -203,10 +204,10 @@ jobs:
203204
uses: lambda-feedback/Database-Testing/.github/workflows/test_evaluation_function.yml@main
204205
needs: [setup, deploy-staging]
205206
with:
206-
endpoint: ${{ inputs.test-api-endpoint }}${{ needs.setup.outputs.evaluation_function_name }}
207207
eval_function: ${{ needs.setup.outputs.evaluation_function_name }}
208208
sql_limit: 500
209209
secrets:
210+
TEST_API_ENDPOINT: ${{ secrets.TEST_API_ENDPOINT }}
210211
DB_USER: ${{ secrets.DB_USER }}
211212
DB_PASSWORD: ${{ secrets.DB_PASSWORD }}
212213
DB_HOST: ${{ secrets.DB_HOST }}

0 commit comments

Comments
 (0)