Merge pull request #198 from lambda-feedback/tr169-flag-for-detailed-feedback

KarlLundengaard · web-flow · commit ec4ef08bc9a2 · 2024-11-23T13:23:05.000Z
Fixed bug where flag was not passed on properly
diff --git a/app/symbolic_comparison_evaluation.py b/app/symbolic_comparison_evaluation.py
@@ -833,7 +833,7 @@ def symbolic_comparison(response, answer, params, eval_response) -> dict:
         "atol": (params.get("atol", 0)),
         "rtol": (params.get("rtol", 0)),
         "numerical": params.get("numerical", False),
-        
+        "detailed_feedback": params.get("detailed_feedback", False),
     }
     criteria_graphs = create_criteria_graphs(criteria_parsed, parameters_dict)
 
diff --git a/app/symbolic_comparison_evaluation_tests.py b/app/symbolic_comparison_evaluation_tests.py
@@ -1388,6 +1388,7 @@ def test_syntactical_comparison(self, response, answer, criteria, value, feedbac
                     'atol': 0,
                 }
             ),
+            ("-10225", "-2525", "response = a*50 + d*51*25 where a=77; d=-5", False, ["response candidates 50*a - 1275*d", "response = a*50 + d*51*25 where a=77; d=-5_FALSE", "response = a*50 + d*51*25 where a=77; d=-5_ONE_ADDITION_TO_SUBTRACTION"], {'detailed_feedback': True}),
         ]
     )
     def test_criteria_where_numerical_comparison(self, response, answer, criteria, value, feedback_tags, additional_params):

Original file line number	Diff line number	Diff line change
`@@ -833,7 +833,7 @@ def symbolic_comparison(response, answer, params, eval_response) -> dict:`
`833`	`833`	`"atol": (params.get("atol", 0)),`
`834`	`834`	`"rtol": (params.get("rtol", 0)),`
`835`	`835`	`"numerical": params.get("numerical", False),`
`836`		`-`
	`836`	`+ "detailed_feedback": params.get("detailed_feedback", False),`
`837`	`837`	`}`
`838`	`838`	`criteria_graphs = create_criteria_graphs(criteria_parsed, parameters_dict)`
`839`	`839`
Original file line number	Diff line number	Diff line change
`@@ -1388,6 +1388,7 @@ def test_syntactical_comparison(self, response, answer, criteria, value, feedbac`
`1388`	`1388`	`'atol': 0,`
`1389`	`1389`	`}`
`1390`	`1390`	`),`
	`1391`	`+ ("-10225", "-2525", "response = a50 + d5125 where a=77; d=-5", False, ["response candidates 50a - 1275d", "response = a50 + d5125 where a=77; d=-5_FALSE", "response = a50 + d51*25 where a=77; d=-5_ONE_ADDITION_TO_SUBTRACTION"], {'detailed_feedback': True}),`
`1391`	`1392`	`]`
`1392`	`1393`	`)`
`1393`	`1394`	`def test_criteria_where_numerical_comparison(self, response, answer, criteria, value, feedback_tags, additional_params):`