Merge pull request #200 from lambda-feedback/tr169-flag-for-detailed-feedback

Improved some of the detailed feedback messages

Author: KarlLundengaard

app/feedback/symbolic_comparison.py

@@ -79,9 +79,9 @@
 }[tag]
 feedback_generators["IDENTIFY_REASON"] = lambda tag: lambda inputs: {
     "UNKNOWN": None,
-    "ONE_ADDITION_TO_SUBTRACTION": f"{inputs['criterion'].children[0].content_string()} is true if one addition is changed to a subtraction or vice versa.",
-    "ONE_EXPONENT_FLIP": f"{inputs['criterion'].children[0].content_string()} is true if one exponent has its sign changed.",
-    "ONE_SWAP_ADDITION_AND_MULTIPLICATION": f"{inputs['criterion'].children[0].content_string()} is true if one addition is replaced with a multiplication or vice versa.",
+    "ONE_ADDITION_TO_SUBTRACTION": f"It is likely that an addition was replaced with a subtraction (or vice versa) when calculating the response.",
+    "ONE_EXPONENT_FLIP": f"It is likely that some exponent had the incorrect sign, or that a multiplication was replaced by a division (or vice versa).",
+    "ONE_SWAP_ADDITION_AND_MULTIPLICATION": f"It is likely that an addition was replaced with a multiplication or vice versa.",
 }[tag]
 feedback_generators["GET_CANDIDATES"] = lambda tag: lambda inputs: None
 feedback_generators["SYNTACTICAL_EQUIVALENCE"] = lambda tag: lambda inputs: {

app/symbolic_comparison_evaluation_tests.py

@@ -1175,6 +1175,7 @@ def test_no_reserved_keywords_in_old_format_input_symbol_alternatives(self):
                 }
             ),
             ("-2525", "-2525", "response = a*50 + d*51*25 where a=77; d=-5", True, [], {}),
+            ("-3150", "-3150", "response = a*50 + d*50*25 where a=373/4; d=-25/4", True, [], {}),
             ("4/9", "(2/9*(3*b-2)^(3/2)-b^2/4-b)-(2/9*(3*a-2)^(3/2)-a^2/4-a)", "response = answer where a=2; b=6", True, [], {}),
             ("0", "0", "2*tan(response)*tan(response) = 0", True, [], {}),
         ]