Merge pull request #190 from lambda-feedback/tr166-printing-floating-point-approximation-of-large-numbers

Changed printing of large numbers when generating simplified response

Author: KarlLundengaard

app/quantity_comparison_evaluation_tests.py

@@ -251,5 +251,17 @@ def test_radians_to_frequency(self):
         result = evaluation_function(res, ans, params, include_test_data=True)
         assert result["is_correct"] is True
 
+    def test_print_floating_point_approximation_of_very_large_numbers(self):
+        ans = "2.47*10^4 kg/s"
+        res = "2.47**10^4 kg/s"  # This number is large enough than attempting to turn it into a string will cause an error
+        params = {
+            'rtol': 0.005,
+            'comparison': 'expression',
+            'strict_syntax': False,
+            'physical_quantity': True,
+        }
+        result = evaluation_function(res, ans, params, include_test_data=True)
+        assert result["is_correct"] is False
+
 if __name__ == "__main__":
     pytest.main(['-xk not slow', "--tb=line", os.path.abspath(__file__)])

app/symbolic_comparison_evaluation.py

@@ -1,5 +1,5 @@
 from sympy.parsing.sympy_parser import T as parser_transformations
-from sympy import Abs, Equality, latex, pi, Symbol, Add, Pow, Mul, N
+from sympy import Abs, Equality, latex, pi, Symbol, Add, Pow, Mul, N, nfloat
 from sympy.core.function import UndefinedFunction
 from sympy.printing.latex import LatexPrinter
 from copy import deepcopy
@@ -776,7 +776,10 @@ def symbolic_comparison(response, answer, params, eval_response) -> dict:
     else:
         res_print = parse_expression(response, create_sympy_parsing_params(printing_params))
     eval_response.latex = LatexPrinter({"symbol_names": printing_symbols, "mul_symbol": r" \cdot "}).doprint(res_print)
-    eval_response.simplified = str(res)
+    try:
+        eval_response.simplified = str(res)
+    except ValueError:
+        eval_response.simplified = str(nfloat(res, n=6))
 
     if (not isinstance(res_original, Equality)) and isinstance(ans_original, Equality):
         eval_response.is_correct = False