Added flag for generating more detailed feedback when available.

Author: KarlLundengaard

app/feedback/symbolic_comparison.py

@@ -79,7 +79,7 @@
 }[tag]
 feedback_generators["IDENTIFY_REASON"] = lambda tag: lambda inputs: {
     "UNKNOWN": None,
-    "ONE_ADDITION_TO_SUBTRACTION": f"{inputs['criterion'].children[0].content_string()} if one addition is changed to a subtraction or vice versa.",
+    "ONE_ADDITION_TO_SUBTRACTION": f"{inputs['criterion'].children[0].content_string()} is true if one addition is changed to a subtraction or vice versa.",
     "ONE_EXPONENT_FLIP": f"{inputs['criterion'].children[0].content_string()} is true if one exponent has its sign changed.",
     "ONE_SWAP_ADDITION_AND_MULTIPLICATION": f"{inputs['criterion'].children[0].content_string()} is true if one addition is replaced with a multiplication or vice versa.",
 }[tag]

app/symbolic_comparison_evaluation.py

@@ -543,12 +543,16 @@ def get_candidates(unused_input):
                 candidates = set(["response candidates "+", ".join([str(e) for e in values_and_expressions[response_value]])])
                 return candidates
             for (group_label, group_info) in variation_groups.items():
+                if local_parameters.get("detailed_feedback", False) is True:
+                    feedback_generator_label = group_label
+                else:
+                    feedback_generator_label = "UNKNOWN"
                 graph.attach(
                     label+"_IDENTIFY_REASON",
                     label+"_"+group_label,
                     summary=group_info["summary"](expression_to_vary, group_info["variations"]),
                     details=group_info["details"](expression_to_vary, group_info["variations"]),
-                    feedback_string_generator=symbolic_feedback_generators["IDENTIFY_REASON"]("UNKNOWN")
+                    feedback_string_generator=symbolic_feedback_generators["IDENTIFY_REASON"](feedback_generator_label)
                 )
                 graph.attach(
                     label+"_"+group_label,

app/symbolic_comparison_evaluation_tests.py

@@ -1175,6 +1175,8 @@ def test_no_reserved_keywords_in_old_format_input_symbol_alternatives(self):
                 }
             ),
             ("-2525", "-2525", "response = a*50 + d*51*25 where a=77; d=-5", True, [], {}),
+            ("4/9", "(2/9*(3*b-2)^(3/2)-b^2/4-b)-(2/9*(3*a-2)^(3/2)-a^2/4-a)", "response = answer where a=2; b=6", True, [], {}),
+            ("0", "0", "2*tan(response)*tan(response) = 0", True, [], {}),
         ]
     )
     def test_criteria_based_comparison(self, response, answer, criteria, value, feedback_tags, additional_params):