Skip to content

Commit 963cbe9

Browse files
Merge pull request #152 from lambda-feedback/tr129-experiment-with-syntactical-equivalence
Further attempt at fixing bug with feedback generation
2 parents 023c187 + d839040 commit 963cbe9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

app/feedback/symbolic_comparison.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
"FALSE": "The response can be simplified further.",
9999
}[tag]
100100
feedback_generators["SAME_FORM"] = lambda tag: lambda inputs: {
101-
"CARTESIAN": None,
102-
"EXPONENTIAL": None,
101+
"CARTESIAN": "Response and answer are both written on Cartesian form", # None,
102+
"EXPONENTIAL": "Response and answer are both written on exponential form", # None,
103103
"UNKNOWN": "The response is not written on the expected form.",
104104
}[tag]

app/symbolic_comparison_evaluation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ def same_symbols(unused_input):
298298
label+"_SAME_FORM"+"_UNKNOWN",
299299
summary="Cannot determine if "+str(lhs)+" and "+str(rhs)+" are written on the same form",
300300
details="Cannot determine if "+str(lhs)+" and "+str(rhs)+" are written on the same form.",
301-
feedback_string_generator=symbolic_feedback_generators["SAME_SYMBOLS"]("UNKNOWN"),
301+
feedback_string_generator=symbolic_feedback_generators["SAME_FORM"]("UNKNOWN"),
302302
)
303303

304304
graph.attach(label+"_SAME_FORM"+"_UNKNOWN", END.label)

0 commit comments

Comments
 (0)