Skip to content

Commit 8617803

Browse files
Merge pull request #205 from lambda-feedback/tr173-changed-preview-code-gen-for-latex-response-with-pm
Found a way to solve the original problem without generating code for…
2 parents d4ea32c + 0635121 commit 8617803

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

Diff for: app/preview_utilities.py

-4
Original file line numberDiff line numberDiff line change
@@ -89,17 +89,13 @@ def parse_latex(response: str, symbols: SymbolDict, simplify : bool, parameters=
8989
raise ValueError(str(e))
9090

9191
if (pm_placeholder is not None) or (mp_placeholder is not None):
92-
result_str_set = set()
9392
result_str = str(expression)
9493
for ph in [(pm_placeholder, "plus_minus"), (mp_placeholder, "minus_plus")]:
9594
if ph[0] is not None:
9695
result_str = result_str.replace("*"+ph[0]+"*", " "+ph[1]+" ")
9796
result_str = result_str.replace(ph[0]+"*", " "+ph[1]+" ")
9897
result_str = result_str.replace("*"+ph[0], " "+ph[1]+" ")
9998
result_str = result_str.replace(ph[0], " "+ph[1]+" ")
100-
for expr in create_expression_set(result_str, parameters):
101-
result_str_set.add(expr)
102-
result_str = '{'+', '.join(result_str_set)+'}'
10399
else:
104100
result_str = str(expression.xreplace(substitutions))
105101

Diff for: app/symbolic_comparison_preview_tests.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def test_latex_with_plus_minus(self):
9696
)
9797
result = preview_function(response, params)
9898
preview = result["preview"]
99-
assert preview.get("sympy") in ['{3*i/sqrt(5), - 3*i/sqrt(5)}', '{- 3*i/sqrt(5), 3*i/sqrt(5)}']
99+
assert preview.get("sympy") == ' plus_minus 3*i/sqrt(5)'
100100
assert preview.get("latex") == r'\pm \frac{3}{\sqrt{5}} i'
101101

102102
def test_latex_conversion_preserves_default_symbols(self):

0 commit comments

Comments
 (0)