Merge pull request #186 from lambda-feedback/tr161-wrong-conversion-factor-for-radians

Changed conversion factor for raidans

Author: KarlLundengaard

app/quantity_comparison_evaluation_tests.py

@@ -240,5 +240,16 @@ def test_MECH60001_dynamic_signals_error_with_dB(self):
         result = evaluation_function(res, ans, params, include_test_data=True)
         assert result["is_correct"] is True
 
+    def test_radians_to_frequency(self):
+        ans = "2*pi*f radian/second"
+        res = "f Hz"
+        params = {
+            "strict_syntax": False,
+            "physical_quantity": True,
+            "elementary functions": True
+        }
+        result = evaluation_function(res, ans, params, include_test_data=True)
+        assert result["is_correct"] is True
+
 if __name__ == "__main__":
     pytest.main(['-xk not slow', "--tb=line", os.path.abspath(__file__)])

app/unit_system_conversions.py

@@ -79,7 +79,7 @@
 This is the subset of common symbols whose short form symbols are allowed
 """
 set_of_very_common_units_in_SI = {
-    ('radian',    'r',   '(1)',                                   tuple(),                  ('radians',)),  # Note: here 'r' is used instead of the more common 'rad' to avoid collision
+    ('radian',             'r',   '(1/(2*pi))',                   tuple(),                  ('radians',)),  # Note: here 'r' is used instead of the more common 'rad' to avoid collision
     ('steradian', 'sr',  '(1)',                                   tuple(),                  ('steradians',)),
     ('minute',            'min', '(60*second)',                   tuple(),                  ('minutes',)),
     ('hour',              'h',   '(3600*second)',                 tuple(),                  ('hours',)),