Skip to content

Commit cc325f5

Browse files
fix: change response-answer logic
1 parent bcd28bc commit cc325f5

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

app/evaluation.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
import os
2-
from typing import Any, TypedDict
2+
from typing import TypedDict
33
import requests
44
from dotenv import load_dotenv
55
load_dotenv()
66

77
class Result(TypedDict):
88
is_correct: bool
99

10-
11-
def evaluation_function(response: Any, answer: Any, params: Any) -> Result:
10+
def evaluation_function(response, answer, params) -> Result:
1211
"""
1312
Function used to evaluate a student response.
1413
---
@@ -38,10 +37,12 @@ def evaluation_function(response: Any, answer: Any, params: Any) -> Result:
3837
if len(response) != 6:
3938
raise Exception("Connection ID must be 6 characters long")
4039

41-
api_response = requests.get(f"{os.environ.get('API_CONNECTION')}/{api_endpoint}{response}")
42-
api_response.raise_for_status()
40+
api_response = requests.get(f"{os.environ.get("API_CONNECTION")}/{api_endpoint}{response}")
4341
api_data = api_response.json()
44-
is_correct = api_data == answer
42+
if api_data == params.get('correct_answer', None):
43+
is_correct = True
44+
else:
45+
is_correct = False
4546
except requests.RequestException as e:
4647
print(f"Error API connection: {e}")
4748
is_correct = False

0 commit comments

Comments
 (0)