Skip to content

Commit 062230f

Browse files
committed
Added missing security features to API, Upgraded remark preset
1 parent 561f311 commit 062230f

File tree

3 files changed

+27
-8
lines changed

3 files changed

+27
-8
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"nyc": "^11.2.1",
5858
"prettier": "^1.7.0",
5959
"remark-cli": "^4.0.0",
60-
"remark-preset-github": "^0.0.6",
60+
"remark-preset-github": "^0.0.7",
6161
"supertest": "^3.0.0",
6262
"xo": "^0.19.0"
6363
},

template/api.js

+19
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ const Logger = require('@ladjs/logger');
1818
const Graceful = require('@ladjs/graceful');
1919
const Mongoose = require('@ladjs/mongoose');
2020
const ip = require('ip');
21+
const conditional = require('koa-conditional-get');
22+
const cors = require('kcors');
23+
const etag = require('koa-etag');
24+
const helmet = require('koa-helmet');
2125

2226
const helpers = require('./helpers');
2327
const config = require('./config');
@@ -79,6 +83,21 @@ app.use(
7983
})
8084
);
8185

86+
// conditional-get
87+
app.use(conditional());
88+
89+
// etag
90+
app.use(etag());
91+
92+
// cors
93+
app.use(cors(config.cors));
94+
95+
// TODO: add `cors-gate`
96+
// <https://github.com/mixmaxhq/cors-gate/issues/6>
97+
98+
// security
99+
app.use(helmet());
100+
82101
// remove trailing slashes
83102
app.use(removeTrailingSlashes());
84103

yarn.lock

+7-7
Original file line numberDiff line numberDiff line change
@@ -5140,9 +5140,9 @@ remark-parse@^4.0.0:
51405140
vfile-location "^2.0.0"
51415141
xtend "^4.0.1"
51425142

5143-
remark-preset-github@^0.0.6:
5144-
version "0.0.6"
5145-
resolved "https://registry.yarnpkg.com/remark-preset-github/-/remark-preset-github-0.0.6.tgz#48dc9574f2ae59a94ccaee1a63a8f4f0826b0275"
5143+
remark-preset-github@^0.0.7:
5144+
version "0.0.7"
5145+
resolved "https://registry.yarnpkg.com/remark-preset-github/-/remark-preset-github-0.0.7.tgz#4611fdf5451c2b142a7e2d9eadfb22b8acc3bade"
51465146
dependencies:
51475147
remark-comment-config "^5.0.0"
51485148
remark-contributors "^3.1.0"
@@ -5191,7 +5191,7 @@ remark-preset-github@^0.0.6:
51915191
remark-toc "^4.0.0"
51925192
remark-validate-links "^7.0.0"
51935193
retext-english "^3.0.0"
5194-
retext-preset-github "^0.0.3"
5194+
retext-preset-github "^0.0.4"
51955195
unified "^6.0.0"
51965196

51975197
remark-preset-lint-recommended@^3.0.1:
@@ -5434,9 +5434,9 @@ retext-indefinite-article@^1.1.0:
54345434
unist-util-is "^2.0.0"
54355435
unist-util-visit "^1.1.0"
54365436

5437-
retext-preset-github@^0.0.3:
5438-
version "0.0.3"
5439-
resolved "https://registry.yarnpkg.com/retext-preset-github/-/retext-preset-github-0.0.3.tgz#75c88efe6bad81a6c1246253f98c76f15e6d1e3f"
5437+
retext-preset-github@^0.0.4:
5438+
version "0.0.4"
5439+
resolved "https://registry.yarnpkg.com/retext-preset-github/-/retext-preset-github-0.0.4.tgz#9883f2f347dea3d1280885dddf50b530ee60dac5"
54405440
dependencies:
54415441
retext-contractions "^2.1.0"
54425442
retext-diacritics "^1.2.0"

0 commit comments

Comments
 (0)