fix: Ensure monitoring containers start by copying configs #6745
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devyubin
added
comp:installer
Copilot finished reviewing on behalf of
devyubin
November 13, 2025 00:18
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for three observability tools (OpenTelemetry Collector, Loki, and Tempo) to the Backend.AI installation process by ensuring their configuration files are copied during the halfstack installation.
Key changes:
- Added three new config file references (
otel-collector-config.yaml,loki-config.yaml,tempo-config.yaml) to be copied during installation - Updated the
install_halfstackmethod to include these configuration files in the copy process
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ai/backend/install/context.py | Added three copy_config calls to copy observability tool configurations during halfstack installation |
| src/ai/backend/install/configs/otel-collector-config.yaml | Added symlink to OpenTelemetry Collector configuration file |
| src/ai/backend/install/configs/loki-config.yaml | Added symlink to Loki configuration file |
| src/ai/backend/install/configs/tempo-config.yaml | Added symlink to Tempo configuration file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HyeockJinKim
force-pushed
the
main
branch
4 times, most recently
from
1a10632 to
2d8c9ea
Compare
HyeockJinKim
approved these changes
Nov 24, 2025
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 24, 2025
Backported-from: main (25.17) Backported-to: 25.15 Backport-of: 6745
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
…6898) Co-authored-by: devyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6744 (BA-3035)
This pull request updates the installation process for observability tools by adding support for OpenTelemetry Collector, Loki, and Tempo. The main changes involve including new configuration files and ensuring they are copied during the installation routine.
Observability stack configuration:
otel-collector-config.yaml,loki-config.yaml, andtempo-config.yamlsymlinks to thesrc/ai/backend/install/configsdirectory, referencing their respective locations in the central configs folder.install_halfstackmethod incontext.pyto copy these new configuration files during installation.Checklist: (if applicable)