Adjust comments about cache and add debug logs

Author: MichalKalke

components/buildless-serverless/internal/controller/cache/cache.go

@@ -15,10 +15,10 @@ type InMemoryCache interface {
 	Delete(any)
 }
 
-// inMemoryManifestCache provides an in-memory processor to store serverless Spec and rendered chart manifest. By using sync.Map for caching,
+// inMemoryCache provides an in-memory processor to store buildless serverless key values pairs with timestamp. By using sync.Map for caching,
 // concurrent operations to the processor from diverse reconciliations are considered safe.
 //
-// Inside the processor is stored chart manifest with used custom flags by client.ObjectKey key.
+// Inside the processor is stored last commit with which was git function created by repository url and reference as the key.
 type inMemoryCache struct {
 	processor sync.Map
 	timeout   time.Duration
@@ -29,15 +29,15 @@ type storageObject struct {
 	value     string
 }
 
-// NewInMemoryManifestCache returns a new instance of inMemoryManifestCache.
+// NewInMemoryCache returns a new instance of inMemoryCache.
 func NewInMemoryCache(timeout time.Duration) *inMemoryCache {
 	return &inMemoryCache{
 		processor: sync.Map{},
 		timeout:   timeout,
 	}
 }
 
-// Get loads the ServerlessSpecManifest from inMemoryManifestCache for the passed client.ObjectKey.
+// Get loads from inMemoryCache for the passed key.
 func (r *inMemoryCache) Get(key any) string {
 	rawValue, ok := r.processor.Load(key)
 	if !ok {
@@ -51,13 +51,13 @@ func (r *inMemoryCache) Get(key any) string {
 	return value.value
 }
 
-// Set saves the passed flags and manifest into inMemoryManifestCache for the client.ObjectKey.
+// Set saves the passed last commit with which was git function created in inMemoryCache for the passed key.
 func (r *inMemoryCache) Set(key any, lastCommit string) {
 	now := time.Now()
 	r.processor.Store(key, &storageObject{now, lastCommit})
 }
 
-// Delete deletes flags and manifest from inMemoryManifestCache for the passed client.ObjectKey.
+// Delete deletes last commit with which was git function created from inMemoryCache for the passed key.
 func (r *inMemoryCache) Delete(key any) {
 	r.processor.Delete(key)
 }

components/buildless-serverless/internal/controller/fsm/fsm.go

@@ -106,7 +106,8 @@ func New(client client.Client, functionConfig config.FunctionConfig, instance *s
 		FunctionConfig: functionConfig,
 		Client:         client,
 		Scheme:         scheme,
-		GitChecker:     git.GoGitCommitChecker{Cache: cache},
+		GitChecker: git.GoGitCommitChecker{Cache: cache,
+			Log: log},
 	}
 	sm.State.saveStatusSnapshot()
 	return &sm

components/buildless-serverless/internal/controller/git/commit_checker.go

@@ -6,6 +6,7 @@ import (
 	"github.com/go-git/go-git/v5/storage/memory"
 	"github.com/kyma-project/serverless/internal/controller/cache"
 	"github.com/pkg/errors"
+	"go.uber.org/zap"
 )
 
 //go:generate mockery --name=LastCommitChecker --output=automock --outpkg=automock --case=underscore
@@ -15,6 +16,7 @@ type LastCommitChecker interface {
 
 type GoGitCommitChecker struct {
 	Cache cache.InMemoryCache
+	Log   *zap.SugaredLogger
 }
 
 type LastCommitKey struct {
@@ -32,6 +34,7 @@ func (g GoGitCommitChecker) GetLatestCommit(url, reference string, gitAuth *GitA
 		lastCommit = g.Cache.Get(commitKey)
 	}
 	if lastCommit != "" {
+		g.Log.Debugf("Last commit from cache for %s %s is %s", url, reference, lastCommit)
 		return lastCommit, nil
 	}
 
@@ -60,6 +63,7 @@ func (g GoGitCommitChecker) GetLatestCommit(url, reference string, gitAuth *GitA
 	}
 
 	lastCommit = ref.Hash().String()
+	g.Log.Debugf("Last commit from repository for %s %s is %s ", url, reference, lastCommit)
 	g.Cache.Set(commitKey, lastCommit)
 
 	return lastCommit, nil