Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submission Pipeline] Create decide-if-modulectl-command.sh script and reference it in the workflow #152

Open
3 tasks
nesmabadr opened this issue Feb 4, 2025 · 0 comments

Comments

@nesmabadr
Copy link
Contributor

nesmabadr commented Feb 4, 2025

Description

Create a decide-if-modulectl-command.sh in the test-infra/ado/scripts which reads the module_config and returns true if we should use modulectl, or false otherwise. This could be done based on the icons field (since it is mandatory in the modulectl) in the module-config, so if there is an icons field, the script should return true, otherwise false.

  • Use collect-module-info.sh as a reference how to fetch the module-config file when a PR is created.

We also need to add this script as a step in the test-infra/ado/templates/submission-pipeline.yaml and only execute the following (already existing) steps if the result is false:

  • download_kyma_cli
  • validate_module_changes
  • kyma_alpha_create_module

Reasons

We need to support both Kyma-cli and modulectl depending on the module-config file provided.

ACs

  • Create decide-if-modulectl-command.sh script
  • Add it as a step in the submission-pipeline workflow
  • Add a condition to execute the above-mentioned steps if the output of the script is false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant