Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test generateModuleStatus #2205

Closed
1 task done
c-pius opened this issue Jan 23, 2025 · 0 comments · Fixed by #2356
Closed
1 task done

Unit test generateModuleStatus #2205

c-pius opened this issue Jan 23, 2025 · 0 comments · Fixed by #2356
Assignees
@ruanxin
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@c-pius
Copy link
Contributor

c-pius commented Jan 23, 2025 •
edited by janmedrek
Loading

Description

We should unit test generateModuleStatus of runner.go. The method is critical for writing the module status and we already have various branches within the func depending on expected cases. These branches should be covered by explicit tests so that we don't accidentially break the user facing status when refactoring the code or adding new functionality.

Reasons

Follow-up from #2200
See also: https://github.com/kyma-project/lifecycle-manager/pull/2200/files#r1926542449

To future proof for further refactorings.

Acceptance Criteria

  • unit tests for all branches of generateModuleStatus

Feature Testing

No response

Testing approach

No response

Attachments

No response
@c-pius c-pius added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2025
@c-pius c-pius mentioned this issue Jan 23, 2025
Merged
@lindnerby lindnerby self-assigned this Feb 27, 2025
@lindnerby lindnerby linked a pull request Mar 28, 2025 that will close this issue
chore: Increase test coverage for generating kyma.status.modules #2356
Merged
@lindnerby lindnerby assigned ruanxin and unassigned lindnerby Mar 28, 2025
@c-pius c-pius self-assigned this Apr 2, 2025
@c-pius c-pius removed their assignment Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruanxin ruanxin

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Increase test coverage for generating kyma.status.modules lindnerby/lifecycle-manager
3 participants
@ruanxin @c-pius @lindnerby