Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Validating-Webhook skeleton which can be extend to validate fields in RuntimeCR #621

Open
5 tasks
tobiscr opened this issue Jan 27, 2025 · 0 comments
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tobiscr
Copy link
Contributor

tobiscr commented Jan 27, 2025

Description

A new validating webhook is required to ensure RuntimeCR fields fulfil validation rules and misconfiguration are detected before the Shoot-Spec is updated.

The validating webhook should reuse the Gardener cert-manager as KIM Snatch is already following this pattern.

The Webhook has to consider that we will add more and more validation rules in the coming weeks. The architecture has to support such cases and allow an easy extension of validation rules.

AC:

  • Create a technical concept how validation rules will be integrated into the webhook.
    • A simple framework architecture should be provided which support a fast and simple extension of validation rules.
    • Share the concept within the @kyma-project/framefrog team and collect feedback
  • Validating webhook is created using kubebuilder framework and Gardener cert-manager
  • Simple Framework is implemented (see point 1) within the webhook which allows the execution of multiple validation rules. A validation rule can easily added to the framework.

Reasons

Improve reliability of Kyma RuntimeCR adjustments and avoid risk of misconfigurations of SKR clusters.

Attachments

@tobiscr tobiscr added area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature. labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant