Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with KEB team how we indicate in RuntimeCR a delete request for a cluster and what kind of deletion-policy should be used #617

Closed
5 tasks
tobiscr opened this issue Jan 24, 2025 · 1 comment
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tobiscr
Copy link
Contributor

tobiscr commented Jan 24, 2025

Description

As preparation of the safe deletion of Kyma runtimes, we have to agree on the technical approach how we indicate that a cluster should be disposed.

Proposal:

  • establish deletion-timestamp field:
    • A common pattern in Kuberentes is to set a deletion-timestamp field for resources, which should be removed (e.g. Pods): as soon as this field is set, the Kyma runtime will be disposed by KIM
    • The timestamp can also be used to calculate the remaining retention time of the runtime until it will be finally deleted.
  • define another field containing the deletion policy
    • Related to the requirement to be able to interrupt the final deletion, we could introduce a deletion policy field which defines how the cluster will be removed (e.g. default value is deleteWithRetention but also the option deleteNever or deleteImmediatelly could be supported).

AC:

  • Agree within Framefrogs on the technical approach how disposing (deleting) requests are indicated within the RuntimeCR
    • The solution has to consider an option for measuring the time elapsed since the deletion request was requested to be able to calculate the retention time
    • We want to support options to suspend / immediately execute the final deletion of a cluster: discuss and agree how we track the used deletion approach (e..g by offering an option to define a kind of deletion strategy).
  • Share the agreement with Gophers. Consolidate the proposal with them and come to a final agreements.
    • Document the agreement in an ADR.

Reasons

Establish architectural agreement between Gophers and Framefrogs for the " safe deletion" feature.

Attachments

@tobiscr tobiscr added area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature. labels Jan 24, 2025
@tobiscr tobiscr changed the title Align with KEB team who we indicate in RuntimeCR to delete a cluster and what kind of deletion-policy we support Align with KEB team how we indicate in RuntimeCR to delete a cluster and what kind of deletion-policy we support Jan 24, 2025
@tobiscr tobiscr changed the title Align with KEB team how we indicate in RuntimeCR to delete a cluster and what kind of deletion-policy we support Align with KEB team how we indicate in RuntimeCR a delete request for a cluster and what kind of deletion-policy should be used Jan 24, 2025
@tobiscr
Copy link
Contributor Author

tobiscr commented Feb 5, 2025

Closing it as we detected several technical disadvantages when using hibernation for preventing unintended cluster deletion. Focusing now on #642 .

@tobiscr tobiscr closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant