Error hidden when accessing Gardener configmap shoot-info

[tobiscr]

Description

The ACM is not reporting the error when it tries to detect the domain of the Gardener cluster.

This make debugging unnecessary difficult (e.g. in case of permission errors). We should, beside the error message of not being able to read the domain-name, also report the error message we received from K8s.

See

application-connector-manager/pkg/reconciler/detect_domain.go

Line 30 in b910f97

return stopWithErrorAndRequeue(fmt.Errorf("unable to detect domain"))

AC:

• include the origin error message in the propagated error when firing the error-message again.

Expected result

ACM is showing an error message which includes the root-casue if it's failing to access the shoot-info Configmap.

Actual result

Just the error unable to detect domain is reported, but not the root-cause why it failed to read the Gardener config map.

Steps to reproduce

Simulate to use a non-Gardener cluster by renaming the shoot-info CM or use a K3d cluster. Install ACM manually afterwards and see how it complains about the missing domain.

Troubleshooting