Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jsoo tests #14

Open
10 tasks
haochenx opened this issue Dec 7, 2022 · 0 comments
Open
10 tasks

add jsoo tests #14

haochenx opened this issue Dec 7, 2022 · 0 comments
Assignees
@cannorin

Comments

@haochenx
Copy link
Member

haochenx commented Dec 7, 2022 •
edited
Loading

add test to make sure jsoo compiled programs using prr would load successfully in Node.js.

concrete testing plan

  • under folder nodejs_tests
  • create a test case nodejs_loading_tests.ml using a executable stanza setting modes to js; and add a rule to run the resulting js file with nodejs while adding this rule to the dune target runtest
  • add / make sure that CI on GH runs the test added
@haochenx haochenx mentioned this issue Dec 7, 2022
Closed
11 tasks
@haochenx haochenx mentioned this issue Feb 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cannorin cannorin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haochenx @cannorin