-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to upstream go-control-plane from fork #2719
Comments
/cc @lobkovilya |
xref #2004 |
What I think we can do is to use LinearCache with MuxCache. But I'm looking forward to whether we can make Snapshot an interface in upstream go-control-plane |
|
This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. |
Summary
pkg/util/xds/v3/cache.go
we have a forked version of go-control-plane'sSnapshotCache
type. This was forked so that we can use it for non-Envoy xDS resources.So that we don't have to maintain the fork we should consider
LinearCache
, which allows a single arbitrary resourceSnapshotCache
to be type oblivious, Add a snapshot interface for caching non-Envoy types envoyproxy/go-control-plane#489The text was updated successfully, but these errors were encountered: