Support install_method being 'none' (treydock#49)

Fixes treydock#47

Author: treydock

.fixtures.yml

@@ -8,6 +8,7 @@ fixtures:
       repo: puppetlabs/stdlib
     firewall:
       repo: puppetlabs/firewall
+      ref: '5.0.0'
     mysql:
       repo: puppetlabs/mysql
     concat:

.github/workflows/ci.yaml

@@ -85,8 +85,3 @@ jobs:
         env:
           BEAKER_PUPPET_COLLECTION: ${{ matrix.puppet }}
           BEAKER_set: ${{ matrix.set }}
-          BEAKER_destroy: 'no'
-      - name: Debug failure
-        if: failure()
-        run: |
-          docker exec slurm-${{ matrix.set }} cat /var/log/slurm/slurmd.log

Gemfile

@@ -17,7 +17,7 @@ ruby_version_segments = Gem::Version.new(RUBY_VERSION.dup).segments
 minor_version = ruby_version_segments[0..1].join('.')
 
 group :development do
-  gem "voxpupuli-test", '5.4.1',    require: false
+  gem "voxpupuli-test", '7.0.0',    require: false
   gem "faraday", '~> 1.0',          require: false
   gem "github_changelog_generator", require: false
   gem "puppet-blacksmith",          require: false

manifests/common/install.pp

@@ -13,9 +13,11 @@
   }
   if $install_method == 'package' {
     $install_class = $package_class
-  } else {
+  } elsif $install_method == 'source' {
     $install_class = 'slurm::common::install::source'
   }
 
-  contain $install_class
+  if $install_method != 'none' {
+    contain $install_class
+  }
 }

manifests/init.pp

@@ -188,7 +188,7 @@
 
   # Repo (optional)
   Optional[Variant[Stdlib::HTTPSUrl, Stdlib::HTTPUrl, Pattern[/^file:\/\//]]] $repo_baseurl = undef,
-  Optional[Enum['package','source']] $install_method = undef,
+  Optional[Enum['package','source','none']] $install_method = undef,
   Stdlib::Absolutepath $install_prefix = '/usr',
 
   # Packages

metadata.json

@@ -109,5 +109,5 @@
   ],
   "pdk-version": "2.7.1",
   "template-url": "https://github.com/treydock/pdk-templates.git#master",
-  "template-ref": "heads/master-0-g70732db"
+  "template-ref": "heads/master-0-g76f4dbb"
 }

spec/acceptance/shared_examples/common_config.rb

@@ -6,10 +6,8 @@
     it { is_expected.to be_mode 644 }
     it { is_expected.to be_owned_by 'root' }
     it { is_expected.to be_grouped_into 'root' }
-    # rubocop:disable RSpec/RepeatedDescription
     its(:content) { is_expected.to match %r{^PartitionName=general Default=YES Nodes=slurmd State=UP$} }
     its(:content) { is_expected.to match %r{^NodeName=slurmd CPUs=1 State=UNKNOWN$} }
-    # rubocop:enable RSpec/RepeatedDescription
   end
 
   describe file('/etc/slurm/plugstack.conf'), node: node do

spec/acceptance/shared_examples/common_install.rb

@@ -46,16 +46,19 @@ def packages
     it { is_expected.to be_installed.with_version(RSpec.configuration.slurm_version.to_s) }
   end
 end
+
 shared_examples_for 'common::install-slurmctld' do |node|
   describe package(packages[:slurmctld]), node: node do
     it { is_expected.to be_installed.with_version(RSpec.configuration.slurm_version.to_s) }
   end
 end
+
 shared_examples_for 'common::install-slurmdbd' do |node|
   describe package(packages[:slurmdbd]), node: node do
     it { is_expected.to be_installed.with_version(RSpec.configuration.slurm_version.to_s) }
   end
 end
+
 shared_examples_for 'common::install-slurmrestd' do |node|
   describe package(packages[:slurmrestd]), node: node, unless: packages[:slurmrestd].nil? do
     it { is_expected.to be_installed.with_version(RSpec.configuration.slurm_version.to_s) }

spec/classes/slurm_spec.rb

@@ -4,7 +4,7 @@
 
 describe 'slurm' do
   on_supported_os.each do |os, os_facts|
-    context "on #{os}" do
+    context "with #{os}" do
       let(:facts) do
         os_facts.merge('processors' => { 'count' => 1 })
       end
@@ -46,6 +46,15 @@
         it_behaves_like 'slurm::common::install::source', os_facts
       end
 
+      context 'when install method is none' do
+        let(:param_override) { { install_method: 'none' } }
+
+        it { is_expected.to compile.with_all_deps }
+        it { is_expected.not_to contain_class('slurm::common::install::source') }
+        it { is_expected.not_to contain_class('slurm::common::install::rpm') }
+        it { is_expected.not_to contain_class('slurm::common::install::apt') }
+      end
+
       context 'when slurmd' do
         let(:client) { false }
         let(:slurmd) { true }

spec/shared_examples/slurm_common_install_apt.rb

@@ -31,9 +31,11 @@
 shared_examples_for 'slurm::common::install::apt-slurmd' do
   it { is_expected.to contain_package('slurmd').with_ensure('present').without_require }
 end
+
 shared_examples_for 'slurm::common::install::apt-slurmctld' do
   it { is_expected.to contain_package('slurmctld').with_ensure('present').without_require }
 end
+
 shared_examples_for 'slurm::common::install::apt-slurmdbd' do
   it { is_expected.to contain_package('slurmdbd').with_ensure('present').without_require }
 end