Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document responsibility for invoking admission webhooks #49369

Open
sftim opened this issue Jan 9, 2025 · 1 comment
Open

Document responsibility for invoking admission webhooks #49369

sftim opened this issue Jan 9, 2025 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@sftim
Copy link
Contributor

sftim commented Jan 9, 2025

This is a Feature Request

When someone defines an APIService backed by an aggregated API server, we need readers to be aware that they (and specifically the aggregated API server they deploy)

are responsible for calling out to admission webhooks for the resource types they serve (edited)

(quoting @liggitt)

What would you like to be added

  • clearly mention aggregated API server invocations of webhooks in the pages about admission webhooks
  • mention API server invocations of webhooks in the cluster networking page
  • mention aggregated API server invocations of webhooks in security hardening guides and checklists

Why is this needed
It's a detail that's obvious when you think about it but likely to be missed unless you do

Comments
/language en
/kind feature
/sig api-machinery
/priority backlog

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/backlog Higher priority than priority/awaiting-more-evidence. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

2 participants