Merge branch 'kubernetes:master' into main

einyx · web-flow · commit 6acec847654f · 2025-07-01T07:41:31.000+02:00
diff --git a/cmd/minikube/cmd/config/kubernetes_version.go b/cmd/minikube/cmd/config/kubernetes_version.go
@@ -20,7 +20,7 @@ import (
 	"context"
 	"net/http"
 
-	"github.com/google/go-github/v72/github"
+	"github.com/google/go-github/v73/github"
 	"golang.org/x/mod/semver"
 	"k8s.io/minikube/pkg/minikube/constants"
 )
diff --git a/go.mod b/go.mod
@@ -28,7 +28,7 @@ require (
 	github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
 	github.com/google/go-cmp v0.7.0
 	github.com/google/go-containerregistry v0.20.3
-	github.com/google/go-github/v72 v72.0.0
+	github.com/google/go-github/v73 v73.0.0
 	github.com/google/slowjam v1.1.2
 	github.com/google/uuid v1.6.0
 	github.com/hashicorp/go-getter v1.7.8
diff --git a/go.sum b/go.sum
@@ -1337,8 +1337,8 @@ github.com/google/go-containerregistry v0.5.1/go.mod h1:Ct15B4yir3PLOP5jsy0GNeYV
 github.com/google/go-containerregistry v0.20.3 h1:oNx7IdTI936V8CQRveCjaxOiegWwvM7kqkbXTpyiovI=
 github.com/google/go-containerregistry v0.20.3/go.mod h1:w00pIgBRDVUDFM6bq+Qx8lwNWK+cxgCuX1vd3PIBDNI=
 github.com/google/go-github v17.0.0+incompatible/go.mod h1:zLgOLi98H3fifZn+44m+umXrS52loVEgC2AApnigrVQ=
-github.com/google/go-github/v72 v72.0.0 h1:FcIO37BLoVPBO9igQQ6tStsv2asG4IPcYFi655PPvBM=
-github.com/google/go-github/v72 v72.0.0/go.mod h1:WWtw8GMRiL62mvIquf1kO3onRHeWWKmK01qdCY8c5fg=
+github.com/google/go-github/v73 v73.0.0 h1:aR+Utnh+Y4mMkS+2qLQwcQ/cF9mOTpdwnzlaw//rG24=
+github.com/google/go-github/v73 v73.0.0/go.mod h1:fa6w8+/V+edSU0muqdhCVY7Beh1M8F1IlQPZIANKIYw=
 github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
 github.com/google/go-querystring v1.1.0 h1:AnCroh3fv4ZBgVIf1Iwtovgjaw/GiKJo8M8yD/fhyJ8=
 github.com/google/go-querystring v1.1.0/go.mod h1:Kcdr2DB4koayq7X8pmAG4sNG59So17icRSOU623lUBU=
diff --git a/hack/preload-images/kubernetes.go b/hack/preload-images/kubernetes.go
@@ -20,7 +20,7 @@ import (
 	"context"
 	"strings"
 
-	"github.com/google/go-github/v72/github"
+	"github.com/google/go-github/v73/github"
 
 	"k8s.io/klog/v2"
 )
diff --git a/hack/update/github.go b/hack/update/github.go
@@ -23,7 +23,7 @@ import (
 
 	"golang.org/x/mod/semver"
 
-	"github.com/google/go-github/v72/github"
+	"github.com/google/go-github/v73/github"
 )
 
 const (
diff --git a/hack/update/ingress_version/update_ingress_version.go b/hack/update/ingress_version/update_ingress_version.go
@@ -25,7 +25,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/google/go-github/v72/github"
+	"github.com/google/go-github/v73/github"
 	"golang.org/x/mod/semver"
 	"k8s.io/klog/v2"
 
diff --git a/hack/update/kubeadm_constants/update_kubeadm_constants.go b/hack/update/kubeadm_constants/update_kubeadm_constants.go
@@ -29,7 +29,7 @@ import (
 	"text/template"
 	"time"
 
-	"github.com/google/go-github/v72/github"
+	"github.com/google/go-github/v73/github"
 	"golang.org/x/mod/semver"
 	"k8s.io/klog/v2"
 	"k8s.io/minikube/hack/update"
diff --git a/hack/update/kubernetes_versions_list/update_kubernetes_versions_list.go b/hack/update/kubernetes_versions_list/update_kubernetes_versions_list.go
@@ -23,7 +23,7 @@ import (
 	"sort"
 	"time"
 
-	"github.com/google/go-github/v72/github"
+	"github.com/google/go-github/v73/github"
 	"golang.org/x/mod/semver"
 	"k8s.io/klog/v2"
 	"k8s.io/minikube/hack/update"
diff --git a/hack/update/site_node_version/update_site_node_version.go b/hack/update/site_node_version/update_site_node_version.go
@@ -22,7 +22,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/google/go-github/v72/github"
+	"github.com/google/go-github/v73/github"
 	"golang.org/x/mod/semver"
 	"k8s.io/klog/v2"
 	"k8s.io/minikube/hack/update"
diff --git a/pkg/drivers/vmnet/vmnet.go b/pkg/drivers/vmnet/vmnet.go
@@ -55,6 +55,11 @@ type Helper struct {
 	// will obtain the same MAC address from vmnet.
 	InterfaceID string
 
+	// Offloading is required for krunkit, doss not work with vfkit.
+	// We must use this until libkrun add support for disabling offloading:
+	// https://github.com/containers/libkrun/issues/264
+	Offloading bool
+
 	// Set when vmnet interface is started.
 	macAddress string
 }
@@ -115,13 +120,18 @@ func ValidateHelper() error {
 // machine. The helper will create a unix datagram socket at the specfied path.
 // The client (e.g. vfkit) will connect to this socket.
 func (h *Helper) Start(socketPath string) error {
-	cmd := exec.Command(
-		"sudo",
+	args := []string{
 		"--non-interactive",
 		executablePath,
 		"--socket", socketPath,
 		"--interface-id", h.InterfaceID,
-	)
+	}
+
+	if h.Offloading {
+		args = append(args, "--enable-tso", "--enable-checksum-offload")
+	}
+
+	cmd := exec.Command("sudo", args...)
 
 	// Create vmnet-helper in a new process group so it is not harmed when
 	// terminating the minikube process group.
diff --git a/pkg/minikube/constants/constants_kubeadm_images.go b/pkg/minikube/constants/constants_kubeadm_images.go
@@ -18,6 +18,11 @@ package constants
 
 var (
 	KubeadmImages = map[string]map[string]string{
+		"v1.34.0-alpha.2": {
+			"coredns/coredns": "v1.12.1",
+			"etcd":            "3.5.21-0",
+			"pause":           "3.10",
+		},
 		"v1.33.2": {
 			"coredns/coredns": "v1.12.0",
 			"etcd":            "3.5.21-0",
diff --git a/pkg/minikube/constants/constants_kubernetes_versions.go b/pkg/minikube/constants/constants_kubernetes_versions.go
@@ -21,6 +21,7 @@ package constants
 // ValidKubernetesVersions is a list of Kubernetes versions in order from newest to oldest
 // This is used when outputting Kubernetes versions and to select the latest patch version when unspecified
 var ValidKubernetesVersions = []string{
+	"v1.34.0-alpha.2",
 	"v1.34.0-alpha.1",
 	"v1.33.2",
 	"v1.33.1",
diff --git a/pkg/perf/monitor/github.go b/pkg/perf/monitor/github.go
@@ -22,7 +22,7 @@ import (
 	"os"
 	"time"
 
-	"github.com/google/go-github/v72/github"
+	"github.com/google/go-github/v73/github"
 	"github.com/pkg/errors"
 	"golang.org/x/oauth2"
 )

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ import (`
`20`	`20`	`"context"`
`21`	`21`	`"net/http"`
`22`	`22`
`23`		`- "github.com/google/go-github/v72/github"`
	`23`	`+ "github.com/google/go-github/v73/github"`
`24`	`24`	`"golang.org/x/mod/semver"`
`25`	`25`	`"k8s.io/minikube/pkg/minikube/constants"`
`26`	`26`	`)`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ import (`
`23`	`23`
`24`	`24`	`"golang.org/x/mod/semver"`
`25`	`25`
`26`		`- "github.com/google/go-github/v72/github"`
	`26`	`+ "github.com/google/go-github/v73/github"`
`27`	`27`	`)`
`28`	`28`
`29`	`29`	`const (`