WIP: discover the warmPool in the ASG task

Author: justinsb

Diff for: pkg/model/awsmodel/autoscalinggroup.go

@@ -103,9 +103,9 @@ func (b *AutoscalingGroupModelBuilder) Build(c *fi.CloudupModelBuilderContext) e
 				if warmPool.MaxSize != nil {
 					warmPoolTask.MaxSize = fi.PtrTo(int32(aws.ToInt64(warmPool.MaxSize)))
 				}
-				tsk.WarmPool = warmPoolTask
+				// tsk.WarmPool = warmPoolTask
 			} else {
-				tsk.WarmPool = nil
+				// tsk.WarmPool = nil
 			}
 			c.AddTask(warmPoolTask)
 

Diff for: upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go

@@ -100,8 +100,12 @@ type AutoscalingGroup struct {
 	TargetGroups []*TargetGroup
 	// CapacityRebalance makes ASG proactively replace spot instances when ASG receives a rebalance recommendation
 	CapacityRebalance *bool
-	// WarmPool is the WarmPool config for the ASG
-	WarmPool *WarmPool
+
+	// warmPool is the WarmPool config for the ASG
+	// The WarmPool has a reference to the ASG, so this field would introduce a circular dependency if public.
+	// We need the warmPool here only for terraform, which configures the warmPool inside the ASG.
+	// To avoid the circular dependency, we make the field private.
+	warmPool *WarmPool
 
 	deletions []fi.CloudupDeletion
 }
@@ -1100,10 +1104,10 @@ func (_ *AutoscalingGroup) RenderTerraform(t *terraform.TerraformTarget, a, e, c
 	}
 	tf.SuspendedProcesses = processes
 
-	if e.WarmPool != nil && *e.WarmPool.Enabled {
+	if e.warmPool != nil && *e.warmPool.Enabled {
 		tf.WarmPool = &terraformWarmPool{
-			MinSize: &e.WarmPool.MinSize,
-			MaxSize: e.WarmPool.MaxSize,
+			MinSize: &e.warmPool.MinSize,
+			MaxSize: e.warmPool.MaxSize,
 		}
 	}
 

Diff for: upup/pkg/fi/cloudup/awstasks/autoscalinggroup_test.go

@@ -342,7 +342,7 @@ terraform {
 				MixedOnDemandBase:           fi.PtrTo(int32(4)),
 				MixedOnDemandAboveBase:      fi.PtrTo(int32(30)),
 				MixedSpotAllocationStrategy: fi.PtrTo("capacity-optimized"),
-				WarmPool: &WarmPool{
+				warmPool: &WarmPool{
 					Enabled: fi.PtrTo(true),
 					MinSize: 3,
 					MaxSize: fi.PtrTo(int32(5)),

Diff for: upup/pkg/fi/cloudup/awstasks/warmpool.go

@@ -41,6 +41,7 @@ type WarmPool struct {
 	// MinSize is the smallest number of nodes in the warm pool.
 	MinSize int32
 
+	// AutoscalingGroup is the AutoscalingGroup on which we configure this warmpool.
 	AutoscalingGroup *AutoscalingGroup
 }