Skip to content

Commit 45d76d8

Browse files
committed
Update test case TestGroupConventions to fix sig-etcd as a special case
Signed-off-by: Benjamin Wang <[email protected]>
1 parent 7bbb80f commit 45d76d8

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

groups/groups_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,13 @@ func TestGroupConventions(t *testing.T) {
168168
for _, g := range cfg.Groups {
169169
// groups are easier to reason about if email and name match
170170
expectedEmailId := g.Name + "@kubernetes.io"
171+
// sig-etcd keeps using [email protected], but the name "security"
172+
// has already been used by "[email protected]", so we use
173+
// the name "etcd-security". Refer to discussion in
174+
// https://github.com/kubernetes/k8s.io/pull/6542.
175+
if g.Name == "etcd-security" {
176+
expectedEmailId = "[email protected]"
177+
}
171178
if g.EmailId != expectedEmailId {
172179
t.Errorf("group '%s': expected email '%s', got '%s'", g.Name, expectedEmailId, g.EmailId)
173180
}

0 commit comments

Comments
 (0)