-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Draft: Extending the canary deployment functionality for cookie-based routing #14138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Extending the canary deployment functionality for cookie-based routing #14138
Conversation
…been added in anoligy with similar annotations canary-by-header...
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mavriq The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @mavriq. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
As described here we no longer accept new features: #13002. |
New annotations
canary-by-cookie-patternandcanary-by-cookie-valuehave been added in analogy with similar annotationscanary-by-header-patternandcanary-by-header-valueWhat this PR does / why we need it:
This PR extends the canary deployment functionality for cookie-based routing by adding support for custom values and regex patterns, similar to the existing header-based canary annotations.
Currently,
canary-by-cookieonly supports the hardcoded valuesalwaysandnever.This enhancement allows users to define custom cookie values and patterns for more flexible canary routing scenarios.
New Annotations:
nginx.ingress.kubernetes.io/canary-by-cookie-value: For exact cookie value matchingnginx.ingress.kubernetes.io/canary-by-cookie-pattern: For regex pattern matchingUsage Examples:
This implementation maintains full backward compatibility while providing the same flexible routing capabilities for cookies that were already available for headers.
Types of changes
How Has This Been Tested?
Checklist: