Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split stdout and stderr log stream of container #3288

Open
7 of 11 tasks
knight42 opened this issue May 1, 2022 · 67 comments
Open
7 of 11 tasks

Split stdout and stderr log stream of container #3288

knight42 opened this issue May 1, 2022 · 67 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@knight42
Copy link
Member

knight42 commented May 1, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 1, 2022
@knight42
Copy link
Member Author

knight42 commented May 1, 2022

/sig node
/sig api-machinery
/sig cli

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 1, 2022
@knight42
Copy link
Member Author

/milestone v1.25

@k8s-ci-robot
Copy link
Contributor

@knight42: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

Hello @knight42 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to get the open KEP PR #3289 merged by Enhancements Freeze:

For note, the status of this enhancement is marked as at risk. Thanks for keeping the issue description up-to-date!

@Priyankasaggu11929
Copy link
Member

With KEP PR #3289 merged, this enhancement is ready for the upcoming enhancements freeze.

For note, the status is not marked as tracked in the enhancements tracking sheet. Thank you!

@knight42
Copy link
Member Author

@Priyankasaggu11929 I think the following could be marked as done now:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

@Atharva-Shinde
Copy link
Contributor

Hi @knight42, Enhancements team here again 👋

Checking in as we approach Code Freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure that the following items are completed before the code-freeze:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
    API: Allow Stream to be set in PodLogOptions kubernetes#110794
    Let me know if there are any additional k/k PRs besides the one listed above

Currently, the status of the enhancement is marked as at-risk

Thanks :)

@Atharva-Shinde
Copy link
Contributor

Hey @knight42 reaching out again as we approach Code Freeze at 01:00 UTC on this Wednesday i.e 3rd August 2022.
Try to get this PR kubernetes/kubernetes#110794 merged before the code-freeze :)
The status of the enhancement is still marked as at-risk

@knight42
Copy link
Member Author

knight42 commented Aug 2, 2022

@Atharva-Shinde Hi, I think we need to move it to next release v1.26. Thanks!

@Priyankasaggu11929
Copy link
Member

Thanks for the update @knight42.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 2, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 2, 2022
@marosset
Copy link
Contributor

/milestone v1.26
/label lead-opted-in
(I'm doing this on behalf of @ruiwen-zhao / SIG-node)

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

@kannon92: Reopened this issue.

In response to this:

/reopen

KEP still has a lot of work to go until it is stable. We should keep this issue open.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Closed to In Progress in SIG CLI Dec 4, 2024
@mochizuki875
Copy link
Member

@knight42
Hi, current kep.yaml indicates featuregate-name as SplitStdoutAndStderr.
Is it correct?

feature-gates:
- name: "SplitStdoutAndStderr"

The correct name seems to be PodLogsQuerySplitStreams.
https://github.com/kubernetes/kubernetes/blob/1e55df4985835ac7f07f6c569cc838aa8cd9bcfa/pkg/features/kube_features.go#L499-L500

@knight42
Copy link
Member Author

@mochizuki875 Thank you! I have filed a PR to fix it.

@dipesh-rawat
Copy link
Member

Hello @knight42 👋, 1.33 Enhancements Lead here.

I’m closing milestone 1.32 now. If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33.
Thanks!

/remove-label lead-opted-in
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.32 milestone Jan 12, 2025
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2025
@kannon92
Copy link
Contributor

@knight42 Thank you for opening up kubernetes-sigs/cri-tools#1724 to add this feature to cri-tools.

I hope you can see through the kubectl fix and maybe bring this feature to beta?

@haircommander haircommander moved this from Triage to Proposed for consideration in SIG Node 1.33 KEPs planning Jan 30, 2025
@haircommander haircommander moved this from Proposed for consideration to Triage in SIG Node 1.33 KEPs planning Jan 30, 2025
@knight42
Copy link
Member Author

knight42 commented Feb 3, 2025

I hope you can see through the kubectl fix and maybe bring this feature to beta?

Absolutely! I am working on it.

@haircommander haircommander moved this from Triage to Proposed for consideration in SIG Node 1.33 KEPs planning Feb 4, 2025
@haircommander
Copy link
Contributor

/label lead-opted-in
/milestone v1.33

note: PRR freeze is tomorrow! you need to have a KEP update for this opened before then. Thanks!

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 5, 2025
@kannon92
Copy link
Contributor

kannon92 commented Feb 6, 2025

@knight42

I think we could get this into beta if you work on this soon.

We have the kubectl PR and we would need a KEP update/PRR updates to promote to beta.

Otherwise we will keep this in alpha for 1.33.

@jenshu
Copy link

jenshu commented Feb 7, 2025

Hello @knight42 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage beta for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • to match the latest readme template, can you add in the missing question about resource exhaustion under the Scalability section?
  • in your kep.yaml, the latest-milestone needs to be updated to v1.33
  • in your PRR file, you will need to add an approver for beta

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jenshu jenshu moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 7, 2025
@dipesh-rawat
Copy link
Member

Hi @knight42 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #3288 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jenshu
Copy link

jenshu commented Feb 14, 2025

Hello @knight42 👋, v1.33 Enhancements team here,

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.33, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.33 milestone Feb 14, 2025
@jenshu jenshu moved this from At risk for enhancements freeze to Removed from Milestone in 1.33 Enhancements Tracking Feb 14, 2025
@haircommander haircommander moved this from Proposed for consideration to Documented in SIG Node 1.33 KEPs planning Feb 14, 2025
@haircommander haircommander moved this from Documented to Not for release in SIG Node 1.33 KEPs planning Feb 14, 2025
@haircommander haircommander moved this from Not for release to Removed in SIG Node 1.33 KEPs planning Feb 14, 2025
@knight42
Copy link
Member Author

We have the kubectl PR and we would need a KEP update/PRR updates to promote to beta.

@kannon92 Apologies for the delayed response. I believe we should get kubernetes/kubernetes#128159 merged before pursuing beta. Otherwise, it won’t be convenient for users to test the feature and provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Net New
Status: Removed from Milestone
Status: In Progress
Status: Removed
Status: Tracked for code freeze
Status: Done
Development

No branches or pull requests