fixup! review feedback

Author: pohly

keps/sig-scheduling/5027-dra-admin-controlled-device-attributes/README.md

@@ -276,8 +276,10 @@ type DevicePatch struct {
     // If a ResourceSlice and a DevicePatch define the same attribute or
     // capacity, the value of the DevicePatch is used. If multiple
     // different DevicePatches match the same device, then the one with
-    // the highest priority wins. If the priorities are the same, it is non-deterministic
-    // which patch is used.
+    // the highest priority wins. If priorities are equal, the older
+    // patch wins. This ensures that adding a new patch does not
+    // accidentally change the effect of some existing patch unless
+    // that is clearly intended according to the priority.
     //
     // +optional
     Priority *int

keps/sig-scheduling/5055-dra-device-taints-and-tolerations/README.md

@@ -248,19 +248,24 @@ type BasicDevice struct {
 
     // If specified, the device's taints.
     //
+    // The maximum number of taints is 8.
+    //
     // This is an alpha field and requires enabling the DRADeviceTaints
     // feature gate.
     //
     // +optional
     // +listType=atomic
     // +featureGate=DRADeviceTaints
-    Taints []Taint
+    Taints []DeviceTaint
 }
 
-// The device this Taint is attached to has the "effect" on
+// DeviceTaintsMaxLength is the maximum number of taints per device.
+const DeviceTaintsMaxLength = 8
+
+// The device this DeviceTaint is attached to has the "effect" on
 // any claim and, through the claim, to pods that do not tolerate
 // the Taint.
-type Taint struct {
+type DeviceTaint struct {
     // The taint key to be applied to a device.
     // Must be a label name.
     //
@@ -279,7 +284,7 @@ type Taint struct {
     // nodes is not valid here.
     //
     // +required
-    Effect TaintEffect
+    Effect DeviceTaintEffect
 
     // ^^^^
     //
@@ -316,14 +321,23 @@ type DeviceRequest struct {
     // it has these tainted devices. Once all pods are evicted, the
     // claim will get deallocated.
     //
+    // The maximum number of tolerations is 16.
+    //
+    // This is an alpha field and requires enabling the DRADeviceTaints
+    // feature gate.
+    //
     // +optional
     // +listType=atomic
-    Tolerations []Toleration
+    // +featureGate=DRADeviceTaints
+    Tolerations []DeviceToleration
 }
 
+// DeviceTolerationsMaxLength is the maximum number of tolerations in a DeviceRequest.
+const DeviceTolerationsMaxLength = 16
+
 // The ResourceClaim this Toleration is attached to tolerate any taint that matches
 // the triple <key,value,effect> using the matching operator <operator>.
-type Toleration struct {
+type DeviceToleration struct {
     // Key is the taint key that the toleration applies to. Empty means match all taint keys.
     // If the key is empty, operator must be Exists; this combination means to match all values and all keys.
     // Must be a label name.
@@ -350,7 +364,7 @@ type Toleration struct {
     // When specified, allowed values are NoSchedule and NoExecute.
     //
     // +optional
-    Effect TaintEffect
+    Effect DeviceTaintEffect
 
     // TolerationSeconds represents the period of time the toleration (which must be
     // of effect NoExecute, otherwise this field is ignored) tolerates the taint. By default,
@@ -364,11 +378,11 @@ type Toleration struct {
 // A toleration operator is the set of operators that can be used in a toleration.
 //
 // +enum
-type TolerationOperator string
+type DeviceTolerationOperator string
 
 const (
-    TolerationOpExists TolerationOperator = "Exists"
-    TolerationOpEqual  TolerationOperator = "Equal"
+    DeviceTolerationOpExists DeviceTolerationOperator = "Exists"
+    DeviceTolerationOpEqual  DeviceTolerationOperator = "Equal"
 )
 ```
 
@@ -395,13 +409,15 @@ type DevicePatch struct {
     // are used in multiple places, the same precedence rules as for attributes apply
     // (see the priority field).
     //
+    // The maximum number of tolerations is 16.
+    //
     // This is an alpha field and requires enabling the DRADeviceTaints
     // feature gate.
     //
     // +optional
     // +listType=atomic
     // +featureGate=DRADeviceTaints
-    Taints []Taint
+    Taints []DeviceTaint
 ```
 
 ### Test Plan