Skip to content

Commit 157a1ca

Browse files
committed
Address review commits
1 parent 2b119d4 commit 157a1ca

File tree

1 file changed

+3
-4
lines changed
  • keps/sig-node/3953-node-resource-hot-plug

1 file changed

+3
-4
lines changed

keps/sig-node/3953-node-resource-hot-plug/README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ detect the change in compute capacity, which can bring in further complications.
189189
### Risks and Mitigations
190190

191191
- Change in Swap limit:
192-
- The formula to calculate the swap limit is `<containerMemoryRequest>/<nodeTotalMemory>)*<totalPodsSwapAvailable>`
192+
- The formula to calculate the swap limit is `(<containerMemoryRequest>/<nodeTotalMemory>)*<totalPodsSwapAvailable>`
193193
- With change in nodeTotalMemory and totalPodsSwapAvailable post up-scale, The existing swap limit may not be inline with the
194194
actual swap limit for existing pods.
195195
- This can be mitigated by recalculating the swap limit for the existing pods. However, there can be an associated overhead for
@@ -225,7 +225,6 @@ detect the change in compute capacity, which can bring in further complications.
225225
- Workloads that depend on the CPU-Memory relationships (e.g Processes that depend on NUMA/NUMA alignment.)
226226
- Dependency of external libraries/device drivers to support CPU hotplug as a supported feature.
227227

228-
229228
## Design Details
230229

231230
The diagram below shows the interaction between kubelet, node and cAdvisor.
@@ -281,7 +280,7 @@ Once the capacity of the node is altered, the following are the sequence of even
281280
observed in any of the steps, operation is retried from step 1 along with a `FailedNodeResize` event and condition under the node object.
282281
1. Resizing existing containers:
283282
a. With the increased memory capacity of the nodes, the kubelet proceeds to update fields that are directly related to
284-
the available memory on the host. This would lead to recalculation of oom_score_adj and swap_limits.
283+
the available memory on the host. This would lead to recalculation of swap_limits.
285284
b. This is achieved by invoking the CRI API - UpdateContainerResources.
286285

287286
2. Reinitialise Resource Manager:
@@ -378,7 +377,7 @@ Few of the concerns surrounding hotunplug are listed below
378377
* Since the total capacity of the node has changed, values associated with the nodes memory capacity must be recomputed.
379378
* Handling unplug of reserved CPUs.
380379

381-
we intend to propose a separate KEP dedicated to hotunplug of resources to address the same.
380+
we are proposing a separate KEP [Node Resource Hot-Unplug](https://github.com/kubernetes/enhancements/issues/5578) dedicated to hot-unplug of resources to address the same.
382381

383382
**Proposed Code changes**
384383

0 commit comments

Comments
 (0)